code review 2516041: Enable the codereview extension for go9p.

Enable the codereview extension for go9p.
Add AUTHORS file too, following Go template.

[rog, 2010-10-14 19:11:55]

Hello aam (cc: lucho),

I'd like you to review this change.

[aam, 2010-10-15 17:02:29]

shouldn't there be a codereview/codereview.py in this change too? what's the
[extensions] setting in your .hgrc?

[rog, 2010-10-15 17:37:14]

On 15 October 2010 18:02,  <mirtchovski@gmail.com> wrote:
> shouldn't there be a codereview/codereview.py in this change too? what's
> the [extensions] setting in your .hgrc?

.hgrc isn't included in the repository.

codereview.py doesn't seem to be needed. i took my cue
from the freetype project (which is semi official) which didn't
include codereview.py.

i just did the minimum to get it working. you might want to add more.

[aam, 2010-10-15 18:34:38]

I'd like to see proper documentation on how this is supposed to be used. I only
know of LGTM and "Fixed issue..." but I'm sure there are more. what exactly
should we do here to accept this? Download the patch/apply and commit? Should
you commit (when added to the contributors)?

The rietveld wiki is useless :(

[aam, 2010-10-15 19:06:46]

it seems that this method works:

1: download the raw patch and apply (hget
http://codereview.appspot.com/download/issue2516041_2001.diff | patch -p1)
2: commit + push

eventually we won't have to do this once rog is in the contributors.

andrey

[rog, 2010-10-16 09:38:58]

hg clpatch 2516041
and/or
hg submit 2516041

should do the job. no need for dealing with the raw patch files, i think.

On 15 October 2010 20:06,  <mirtchovski@gmail.com> wrote:
> it seems that this method works:
>
> 1: download the raw patch and apply (hget
> http://codereview.appspot.com/download/issue2516041_2001.diff | patch
> -p1)
> 2: commit + push
>
> eventually we won't have to do this once rog is in the contributors.
>
> andrey
>
> http://codereview.appspot.com/2516041/
>