DescriptionDerived from James Keane's patches
<https://github.com/google/caja/pull/1965> -- thanks to him for spotting
the problem. Issues in our tests and in onreadystatechange were spotted
in testing and additionally fixed.
Allegedly fixes <https://github.com/google/caja/issues/1878>.
* Pass the correct number of arguments to native XMLHttpRequest, rather
than one too many. Among other things, this caused us to incorrectly
default to synchronous XHR.
* Fixed onreadystatechange firing twice after synchronous XHR on Chrome
due to using an unsound browser test rather than a feature test to
decide whether to apply a workaround.
* Fixed lack of argument coercion for some uses of the async parameter.
(Should have no observable effects, so this is just on general
code structure principles.)
Supporting changes:
* Fixed test-cajajs-invocation testBuilderApiNetNoFetch accidentally
depending on that synchronous XHR.
* Increased timeout for preliminary-meta from 10 to 30 seconds as
I have experienced timeouts on that test only frequently, and it is
inherently slow compared to others.
@ a83ec15cf5b13ffbe482cfb31830b7eb5490ccd9
Patch Set 1 #
Total comments: 2
MessagesTotal messages: 4
|