Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3428)

Issue 25073: [issue400608] just testing

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by ajaksu
Modified:
15 years, 1 month ago
Reviewers:
GvR
CC:
report_bugs.python.org
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Description

wish we could expunge the deleted ones

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M static/upload.py View 5 chunks +45 lines, -2 lines 0 comments Download

Messages

Total messages: 2
ajaksu
While this is a test issue, the attached diff is a crude first draft of ...
15 years, 1 month ago (2009-03-06 04:52:50 UTC) #1
GvR
15 years, 1 month ago (2009-03-06 05:36:21 UTC) #2
This is specific to the Python tracker, which Rietveld tries to avoid.  You
could maintain this as a locally modified version, but a better approach would
be to make just enough changes to upload.py itself so that you can write the
rest of this script as a *wrapper* around upload.py.  That's how the Chrome
people manage their workflow, and that's a generally recommended approach: the
wrapper does the project-specific stuff, passing everything to upload.py for the
actual interaction with Rietveld.

PS. What do you mean by "wish we could expunge the deleted ones"?  If you delete
a Rietveld issue it is really gone.  If you merely close it, you can still
delete it later.  But I'm probably missing something.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b