Issue 250270043: Issue 4485: Refactor \partcombine and \autochange iterators

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 250270043: Issue 4485: Refactor \partcombine and \autochange iterators (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by Dan Eble

Modified:
8 years, 9 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Move the \partcombine context state machine from C++ to Scheme and move the part-specific work into a new Part_combine_part_iterator. What remains in Part_combine_iterator is multi-measure rest handling. The part-specific work is now nothing more than changing context at specified times, which is basically what \autochange does. There are still some differences, but most of the implementation of both is now in the common base Change_sequence_iterator.

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -304 lines)			Patch
M	lily/auto-change-iterator.cc	View		1 chunk	+8 lines, -45 lines	0 comments	Download
A	lily/change-sequence-iterator.cc	View		1 chunk	+67 lines, -0 lines	0 comments	Download
A +	lily/include/change-sequence-iterator.hh	View	1	2 chunks	+19 lines, -16 lines	0 comments	Download
M	lily/part-combine-iterator.cc	View		6 chunks	+2 lines, -189 lines	0 comments	Download
A	lily/part-combine-part-iterator.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	ly/music-functions-init.ly	View		2 chunks	+32 lines, -3 lines	0 comments	Download
M	scm/autochange.scm	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	scm/define-music-display-methods.scm	View		2 chunks	+15 lines, -26 lines	0 comments	Download
M	scm/define-music-properties.scm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	scm/define-music-types.scm	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	scm/part-combiner.scm	View		2 chunks	+79 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dan Eble

https://codereview.appspot.com/250270043/diff/1/lily/include/change-sequence-iterator.hh File lily/include/change-sequence-iterator.hh (right): https://codereview.appspot.com/250270043/diff/1/lily/include/change-sequence-iterator.hh#newcode20 lily/include/change-sequence-iterator.hh:20: #ifndef CHANGE_SEQUENCE_ITERATOR_HH This is a new file. I don't ...

8 years, 10 months ago (2015-07-07 02:37:17 UTC) #2

comment

Expand All Messages | Collapse All Messages