Issue 2501041: Fixes issue 1284.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2501041: Fixes issue 1284. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by metaweta

Modified:
15 years, 5 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

document.getElementsByTagName('*') did not contain the virtualized HTML, HEAD, TITLE, and BODY elements.

Patch Set 1 #

Total comments: 2

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	src/com/google/caja/plugin/domita.js	View		1 chunk	+8 lines, -1 line	2 comments	Download
	M	tests/com/google/caja/plugin/domita_test_untrusted.html	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domita.js File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domita.js#newcode3238 src/com/google/caja/plugin/domita.js:3238: return nodes; This change to include body, head, title ...

15 years, 5 months ago (2010-10-14 21:52:52 UTC) #2

metaweta

15 years, 5 months ago (2010-10-14 22:19:56 UTC) #4

http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domit...
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domit...
src/com/google/caja/plugin/domita.js:3238: return nodes;
On 2010/10/14 21:52:53, jasvir wrote:
> This change to include body, head, title and html as potential candidates is
> needed in getElementsByClassName too.

The virtual nodes have no class name, so they can't turn up in a result from
getElementsByClassName.

Expand All Messages | Collapse All Messages