Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 2501041: Fixes issue 1284. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by metaweta
Modified:
15 years, 5 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

document.getElementsByTagName('*') did not contain the virtualized HTML, HEAD, TITLE, and BODY elements.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/com/google/caja/plugin/domita.js View 1 chunk +8 lines, -1 line 2 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
metaweta
15 years, 5 months ago (2010-10-14 00:28:40 UTC) #1
Jasvir
http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domita.js File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domita.js#newcode3238 src/com/google/caja/plugin/domita.js:3238: return nodes; This change to include body, head, title ...
15 years, 5 months ago (2010-10-14 21:52:52 UTC) #2
Jasvir
LGTM++
15 years, 5 months ago (2010-10-14 22:18:36 UTC) #3
metaweta
15 years, 5 months ago (2010-10-14 22:19:56 UTC) #4
http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domit...
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/2501041/diff/1/src/com/google/caja/plugin/domit...
src/com/google/caja/plugin/domita.js:3238: return nodes;
On 2010/10/14 21:52:53, jasvir wrote:
> This change to include body, head, title and html as potential candidates is
> needed in getElementsByClassName too.

The virtual nodes have no class name, so they can't turn up in a result from
getElementsByClassName.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b