Issue 24970043: keySignature-> keyAlterations

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Keith

Modified:
9 years, 12 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

1) keySignature-> keyAlterations to better distingush the sets (keyAlterations, localAlterations) of alterations that determine which accidentals need to be printed, from the graphical object (KeySignature) printed when the key changes. 2) Create 'Documentation/snippets/new/non-traditional-key-signatures.ly' to simplify the example using the new syntax. Presumably the whole-tone scale repeats the same pattern in every octave. 3) makelsr 4) update-with-convert-ly

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : 2.19.6 #

Patch Set 4 : correct text in an old snippet #

Total comments: 1

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -108 lines)			Patch
M	Documentation/de/notation/changing-defaults.itely	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Documentation/es/notation/changing-defaults.itely	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/fr/notation/changing-defaults.itely	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/ja/notation/changing-defaults.itely	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/notation/changing-defaults.itely	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/snippets/defining-an-engraver-in-scheme--ambitus-engraver.ly	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/engravers-one-by-one.ly	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/snippets/makam-example.ly	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/new/defining-an-engraver-in-scheme--ambitus-engraver.ly	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A	Documentation/snippets/new/non-traditional-key-signatures.ly	View	1 2 3	1 chunk	+44 lines, -0 lines	0 comments	Download
M	Documentation/snippets/non-traditional-key-signatures.ly	View	1 2 3	2 chunks	+15 lines, -14 lines	1 comment	Download
M	input/regression/key-signature-padding.ly	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	input/regression/key-signature-scordatura.ly	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	input/regression/key-signature-scordatura-persist.ly	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	input/regression/keys.ly	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/accidental-engraver.cc	View	1	7 chunks	+10 lines, -10 lines	0 comments	Download
M	lily/ambitus-engraver.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/key-engraver.cc	View	1	7 chunks	+12 lines, -12 lines	0 comments	Download
M	lily/pitched-trill-engraver.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ly/engraver-init.ly	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	python/convertrules.py	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	python/musicexp.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	scm/define-context-properties.scm	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	scm/music-functions.scm	View	1	10 chunks	+25 lines, -24 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/24970043/diff/20001/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/24970043/diff/20001/python/convertrules.py#newcode3714 python/convertrules.py:3714: @rule ((2, 19, 5), "keySignature -> keyAlterations") Version number ...

9 years, 12 months ago (2014-05-11 07:00:57 UTC) #1

Keith

9 years, 12 months ago (2014-05-11 08:17:10 UTC) #2

https://codereview.appspot.com/24970043/diff/60001/Documentation/snippets/non...
File Documentation/snippets/non-traditional-key-signatures.ly (left):

https://codereview.appspot.com/24970043/diff/60001/Documentation/snippets/non...
Documentation/snippets/non-traditional-key-signatures.ly:25: will appear in the
reverse order to that in which they are specified.
The simplified version, with the old syntax, is 
http://lsr.di.unimi.it/LSR/Item?id=916

Expand All Messages | Collapse All Messages