Issue 248930043: Makefile fixes for bundletester.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 248930043: Makefile fixes for bundletester.

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by frankban

Modified:
8 years, 10 months ago

Reviewers:
mp+262062, martin.hilton

Visibility:
Public.

Description

Makefile fixes for bundletester. - The "local" env is no longer used by default when JUJU_ENV is not specified. Now the current env is used instead. - The environment is no longer destroyed when ftests complete. - Do not exit if bootstrap returns an error: assume the environment to be already bootstrapped. - Removed the setup phony target to work around a bundletester bug. For more info, see review comments at https://bugs.launchpad.net/charms/+bug/1459345 https://code.launchpad.net/~frankban/charms/trusty/redis/tsting-fixes/+merge/262062 (do not edit description out of merge proposal)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
	M	Makefile	View		6 chunks	+20 lines, -14 lines	0 comments	Download
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

frankban

8 years, 10 months ago (2015-06-16 12:52:36 UTC) #4

*** Submitted:

Makefile fixes for bundletester.

- The "local" env is no longer used by default when 
  JUJU_ENV is not specified. Now the current env is
  used instead.

- The environment is no longer destroyed when ftests
  complete.

- Do not exit if bootstrap returns an error: assume
  the environment to be already bootstrapped.

- Removed the setup phony target to work around a
  bundletester bug.

For more info, see review comments at
https://bugs.launchpad.net/charms/+bug/1459345

R=martin.hilton
CC=
https://codereview.appspot.com/248930043

Expand All Messages | Collapse All Messages