Issue 24820046: Add a dummy block profile for never executed block.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 24820046: Add a dummy block profile for never executed block. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by etienneb

Modified:
10 years, 5 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add a dummy block profile for never executed block. This avoid managing the NULL case when using the API. I found it easier this way. R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=1910

Patch Set 1 : #

Patch Set 2 : rebase #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
M	syzygy/optimize/application_profile.h	View	1	4 chunks	+12 lines, -5 lines	0 comments	Download
M	syzygy/optimize/application_profile.cc	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	syzygy/optimize/application_profile_unittest.cc	View	1	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

etienneb

PTAL. I don't like managing the NULL case, but I don't like to allocate a ...

10 years, 5 months ago (2013-11-12 15:32:08 UTC) #1

etienneb

10 years, 5 months ago (2013-11-19 19:13:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1910 (presubmit successful).

Expand All Messages | Collapse All Messages