Issue 24780043: Move generic bits to container package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 24780043: Move generic bits to container package.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by thumper

Modified:
10 years, 6 months ago

Reviewers:
mp+194757, wallyworld

Visibility:
Public.

Description

Move generic bits to container package. The ContainerManager and the config type to create it are common over both LXC and KVM. Also, network config is similarly generic. Most of this work is just moving types, changing imports and parameter types. https://code.launchpad.net/~thumper/juju-core/container-interface/+merge/194757 Requires: https://code.launchpad.net/~thumper/juju-core/fix-add-machine-test/+merge/194753 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -81 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	container/interface.go	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	container/lxc/lxc.go	View	8 chunks	+21 lines, -61 lines	0 comments	Download
M	container/lxc/lxc_test.go	View	10 chunks	+15 lines, -14 lines	0 comments	Download
A	container/network.go	View	1 chunk	+29 lines, -0 lines	2 comments	Download
M	provider/local/environ.go	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	worker/provisioner/lxc-broker.go	View	4 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wallyworld

LGTM. Very pleased to see this factored out. https://codereview.appspot.com/24780043/diff/1/container/network.go File container/network.go (right): https://codereview.appspot.com/24780043/diff/1/container/network.go#newcode7 container/network.go:7: // ...

10 years, 6 months ago (2013-11-11 22:59:13 UTC) #2

thumper

10 years, 6 months ago (2013-11-12 00:35:44 UTC) #3

https://codereview.appspot.com/24780043/diff/1/container/network.go
File container/network.go (right):

https://codereview.appspot.com/24780043/diff/1/container/network.go#newcode7
container/network.go:7: // BridgeNetwork will have the container use the lxc
bridge.
On 2013/11/11 22:59:14, wallyworld wrote:
> s/lxc/network   ?

Done.

Expand All Messages | Collapse All Messages