Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2448)

Issue 247310043: Matt's MPTCP code

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by Tom Henderson
Modified:
8 years, 9 months ago
Reviewers:
Vedran Miletić
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Matt's MPTCP code for ns-3. This is for reviewing; the patch doesn't apply to ns-3-dev. If you want to run the code, checkout the 'outsourcing_CC' branch from github here: https://github.com/mkheirkhah/mptcp See also these web links for more information: https://www.nsnam.org/wiki/GSOC2015MpTcpImplementation (wiki) http://codereview.appspot.com/248320043 (Morteza Kheirkhah's development branch)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16821 lines, -2284 lines) Patch
A src/applications/helper/mp-tcp-bulk-send-helper.h View 1 chunk +112 lines, -0 lines 0 comments Download
A src/applications/helper/mp-tcp-bulk-send-helper.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A src/applications/helper/mp-tcp-packet-sink-helper.h View 1 chunk +95 lines, -0 lines 0 comments Download
A src/applications/helper/mp-tcp-packet-sink-helper.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M src/core/model/object.h View 10 chunks +11 lines, -11 lines 0 comments Download
M src/core/model/object-base.cc View 10 chunks +18 lines, -11 lines 0 comments Download
M src/core/model/test.cc View 21 chunks +48 lines, -48 lines 0 comments Download
M src/core/model/traced-value.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/model/type-id.cc View 39 chunks +64 lines, -61 lines 0 comments Download
M src/internet/helper/ipv4-address-helper.h View 7 chunks +46 lines, -35 lines 0 comments Download
M src/internet/helper/ipv4-address-helper.cc View 4 chunks +32 lines, -23 lines 0 comments Download
A src/internet/helper/mp-tcp-path-manager-full-helper.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/internet/helper/mp-tcp-path-manager-full-helper.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/internet/model/ipv4-end-point.h View 4 chunks +15 lines, -3 lines 0 comments Download
M src/internet/model/ipv4-end-point.cc View 4 chunks +30 lines, -24 lines 0 comments Download
M src/internet/model/ipv4-end-point-demux.h View 4 chunks +15 lines, -8 lines 0 comments Download
M src/internet/model/ipv4-end-point-demux.cc View 14 chunks +57 lines, -28 lines 0 comments Download
M src/internet/model/ipv4-global-routing.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/internet/model/ipv4-global-routing.cc View 29 chunks +166 lines, -93 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.h View 9 chunks +18 lines, -10 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 40 chunks +108 lines, -66 lines 0 comments Download
A src/internet/model/mp-tcp-cc-coupled.h View 1 chunk +60 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-cc-coupled.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-cc-uncoupled.h View 1 chunk +5 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-cc-uncoupled.cc View 1 chunk +1 line, -0 lines 0 comments Download
A src/internet/model/mp-tcp-id-manager.h View 1 chunk +117 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-id-manager.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-id-manager-impl.h View 1 chunk +143 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-id-manager-impl.cc View 1 chunk +243 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-olia.h View 1 chunk +69 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-olia.cc View 1 chunk +133 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-scheduler.h View 1 chunk +40 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-scheduler-round-robin.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-scheduler-round-robin.cc View 1 chunk +182 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-base.h View 1 chunk +827 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-base.cc View 1 chunk +3648 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-factory.h View 1 chunk +30 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-factory.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-factory-impl.h View 1 chunk +31 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-socket-factory-impl.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-subflow.h View 1 chunk +564 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-subflow.cc View 1 chunk +2357 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-typedefs.h View 1 chunk +339 lines, -0 lines 0 comments Download
A src/internet/model/mp-tcp-typedefs.cc View 1 chunk +484 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-lia.h View 1 chunk +64 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-lia.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket.h View 1 chunk +59 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow-uncoupled.h View 1 chunk +28 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow-uncoupled.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-uncoupled.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-uncoupled.cc View 1 chunk +126 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.h View 9 chunks +107 lines, -17 lines 0 comments Download
M src/internet/model/tcp-header.cc View 11 chunks +313 lines, -47 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.h View 4 chunks +43 lines, -2 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.cc View 8 chunks +84 lines, -8 lines 0 comments Download
M src/internet/model/tcp-socket.h View 3 chunks +19 lines, -18 lines 0 comments Download
M src/internet/model/tcp-socket-base.h View 3 chunks +385 lines, -503 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 26 chunks +1213 lines, -1144 lines 0 comments Download
A src/internet/model/tcp-state.h View 1 chunk +17 lines, -0 lines 0 comments Download
A src/internet/model/tcp-state.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/internet/model/tcp-tx-buffer.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/internet/model/tcp-tx-buffer.cc View 3 chunks +10 lines, -0 lines 0 comments Download
A src/internet/test/mptcp-mapping-test.cc View 1 chunk +213 lines, -0 lines 0 comments Download
A src/internet/test/mptcp-options-test.cc View 1 chunk +432 lines, -0 lines 0 comments Download
A src/internet/test/mptcp-tcp-multi.cc View 1 chunk +725 lines, -0 lines 0 comments Download
A src/internet/test/mptcp-tcp-test.cc View 1 chunk +588 lines, -0 lines 0 comments Download
A src/internet/test/mptcp-test.cc View 1 chunk +773 lines, -0 lines 0 comments Download
M src/network/model/buffer.h View 13 chunks +231 lines, -30 lines 0 comments Download
M src/network/model/buffer.cc View 2 chunks +7 lines, -3 lines 0 comments Download
A src/network/model/sequence-number.h View 1 chunk +389 lines, -0 lines 0 comments Download
M src/network/model/socket.h View 36 chunks +87 lines, -87 lines 0 comments Download
M test.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 1
Vedran Miletić
8 years, 9 months ago (2015-07-13 21:43:31 UTC) #1
Matt and I discussed on IRC how to proceed with this, given the large amount of
code.

Generally, I like the approach. As discussed on IRC, "MPTCP is a shim layer to
aggregate TCP subflows", and Matt's code is designed around this idea (e.g.
MpTcpSocketBase is a subclass of TcpSocketBase), and existing applications
continue to work.

Matt is already working on rebasing this over Natale's refactoring. Once this is
done I suggest the code review made in form of many patches, where each
implements a single feature or so and provides tests and documentation of this
particular feature.

Finally, there is leftover commented code. This is neat to have when developing,
but is not very helpful when reviewing code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b