Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1262)

Issue 246020043: file upload

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by vipul
Modified:
4 years, 2 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

file upload implemented file upload feature by creating a named top level item. Every item uploaded is referred to the ticket's itemid using a new meta field "refers_to". This field is indexed in whoosh.

Patch Set 1 : file upload #

Total comments: 17

Patch Set 2 : file upload: improved query #

Total comments: 7

Patch Set 3 : file upload #

Total comments: 9

Patch Set 4 : add TODO and shorten function #

Total comments: 6

Patch Set 5 : fixed issue of ticket-name prefix in file's item_name #

Total comments: 1

Patch Set 6 : now files uploaded in create view does not disappear in update view #

Total comments: 2

Patch Set 7 : delete duplicate-old-file item, using name of ticket. #

Total comments: 8

Patch Set 8 : removed "else: pass" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -7 lines) Patch
M MoinMoin/constants/keys.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M MoinMoin/items/ticket.py View 1 2 3 4 5 6 7 8 chunks +71 lines, -7 lines 0 comments Download
M MoinMoin/storage/middleware/indexing.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/base.html View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/modify.html View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/submit.html View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 25
vipul
https://codereview.appspot.com/246020043/diff/20001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/20001/MoinMoin/items/ticket.py#newcode164 MoinMoin/items/ticket.py:164: def file_upload(self, data_file): creating item of file uploaded and ...
4 years, 4 months ago (2015-06-11 14:15:13 UTC) #1
Thomas.J.Waldmann
https://codereview.appspot.com/246020043/diff/20001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/20001/MoinMoin/items/ticket.py#newcode166 MoinMoin/items/ticket.py:166: contenttype = data_file.content_type is that always present or could ...
4 years, 4 months ago (2015-06-11 15:44:45 UTC) #2
vipul
https://codereview.appspot.com/246020043/diff/20001/MoinMoin/templates/ticket/base.html File MoinMoin/templates/ticket/base.html (right): https://codereview.appspot.com/246020043/diff/20001/MoinMoin/templates/ticket/base.html#newcode47 MoinMoin/templates/ticket/base.html:47: <a href="{{ url_for('.show_item', item_name=e.fullname) }}" On 2015/06/11 15:44:44, Thomas.J.Waldmann ...
4 years, 4 months ago (2015-06-11 21:10:07 UTC) #3
Thomas.J.Waldmann
https://codereview.appspot.com/246020043/diff/40001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/40001/MoinMoin/items/ticket.py#newcode165 MoinMoin/items/ticket.py:165: item_name = self.fqname.value + '/' + data_file.filename can we ...
4 years, 4 months ago (2015-06-14 17:16:08 UTC) #4
vipul
https://codereview.appspot.com/246020043/diff/160001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/160001/MoinMoin/items/ticket.py#newcode165 MoinMoin/items/ticket.py:165: item_name = self.fqname.value + '/' + data_file.filename I don't ...
4 years, 4 months ago (2015-06-19 15:44:00 UTC) #5
Thomas.J.Waldmann
https://codereview.appspot.com/246020043/diff/160001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/160001/MoinMoin/items/ticket.py#newcode165 MoinMoin/items/ticket.py:165: item_name = self.fqname.value + '/' + data_file.filename On 2015/06/19 ...
4 years, 4 months ago (2015-06-23 16:02:21 UTC) #6
vipul
add TODO and shorten function
4 years, 3 months ago (2015-06-27 07:49:35 UTC) #7
vipul
add TODO and shorten function
4 years, 3 months ago (2015-06-27 08:21:40 UTC) #8
vipul
add TODO and shorten function
4 years, 3 months ago (2015-06-27 08:25:06 UTC) #9
vipul
add TODO and shorten function
4 years, 3 months ago (2015-06-27 08:26:12 UTC) #10
vipul
https://codereview.appspot.com/246020043/diff/260001/MoinMoin/templates/ticket/base.html File MoinMoin/templates/ticket/base.html (right): https://codereview.appspot.com/246020043/diff/260001/MoinMoin/templates/ticket/base.html#newcode44 MoinMoin/templates/ticket/base.html:44: <a href="{{ url_for('.show_item', item_name=file.fullname) }}" for rendering files, I've ...
4 years, 3 months ago (2015-06-27 08:44:54 UTC) #11
sksaurabhkathpalia
https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py#newcode178 MoinMoin/items/ticket.py:178: prefix = self.fqname.value + '/' is self.fqname.value itemid or ...
4 years, 3 months ago (2015-07-01 05:56:48 UTC) #12
vipul
https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py#newcode178 MoinMoin/items/ticket.py:178: prefix = self.fqname.value + '/' On 2015/07/01 05:56:48, sksaurabhkathpalia ...
4 years, 3 months ago (2015-07-01 07:17:20 UTC) #13
sksaurabhkathpalia
On 2015/07/01 07:17:20, vipul wrote: > https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py > File MoinMoin/items/ticket.py (right): > > https://codereview.appspot.com/246020043/diff/260001/MoinMoin/items/ticket.py#newcode178 > ...
4 years, 3 months ago (2015-07-01 07:19:02 UTC) #14
Thomas.J.Waldmann
https://codereview.appspot.com/246020043/diff/260001/MoinMoin/constants/keys.py File MoinMoin/constants/keys.py (right): https://codereview.appspot.com/246020043/diff/260001/MoinMoin/constants/keys.py#newcode60 MoinMoin/constants/keys.py:60: REFERS_TO = u"refers_to" hmm, should that be in the ...
4 years, 3 months ago (2015-07-01 08:54:23 UTC) #15
vipul
please review the new CR. I've added a function which will check if both name ...
4 years, 3 months ago (2015-07-01 09:09:27 UTC) #16
sksaurabhkathpalia
On 2015/07/01 09:09:27, vipul wrote: > please review the new CR. I've added a function ...
4 years, 3 months ago (2015-07-01 11:20:04 UTC) #17
sksaurabhkathpalia
https://codereview.appspot.com/246020043/diff/280001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/280001/MoinMoin/items/ticket.py#newcode174 MoinMoin/items/ticket.py:174: print name remove this print name
4 years, 3 months ago (2015-07-01 11:28:07 UTC) #18
sksaurabhkathpalia
https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py#newcode171 MoinMoin/items/ticket.py:171: for rev in revs: In this you are creating ...
4 years, 3 months ago (2015-07-01 15:55:02 UTC) #19
vipul
https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py#newcode171 MoinMoin/items/ticket.py:171: for rev in revs: On 2015/07/01 15:55:01, sksaurabhkathpalia wrote: ...
4 years, 3 months ago (2015-07-02 12:39:17 UTC) #20
sksaurabhkathpalia
On 2015/07/02 12:39:17, vipul wrote: > https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py > File MoinMoin/items/ticket.py (right): > > https://codereview.appspot.com/246020043/diff/340001/MoinMoin/items/ticket.py#newcode171 > ...
4 years, 3 months ago (2015-07-02 12:45:50 UTC) #21
Thomas.J.Waldmann
https://codereview.appspot.com/246020043/diff/360001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/360001/MoinMoin/items/ticket.py#newcode168 MoinMoin/items/ticket.py:168: query = And([Term(WIKINAME, app.cfg.interwikiname), Term(REFERS_TO, self.meta[NAME])]) .meta[NAME] is a ...
4 years, 3 months ago (2015-07-14 16:17:20 UTC) #22
vipul
https://codereview.appspot.com/246020043/diff/360001/MoinMoin/items/ticket.py File MoinMoin/items/ticket.py (right): https://codereview.appspot.com/246020043/diff/360001/MoinMoin/items/ticket.py#newcode168 MoinMoin/items/ticket.py:168: query = And([Term(WIKINAME, app.cfg.interwikiname), Term(REFERS_TO, self.meta[NAME])]) On 2015/07/14 16:17:20, ...
4 years, 3 months ago (2015-07-17 12:17:29 UTC) #23
Thomas.J.Waldmann
ok, fix the one thing you said in last reply, give it a final test ...
4 years, 2 months ago (2015-08-11 15:34:30 UTC) #24
vipul
4 years, 2 months ago (2015-08-12 07:10:15 UTC) #25
On 2015/08/11 15:34:30, Thomas.J.Waldmann wrote:
> ok, fix the one thing you said in last reply, give it a final test and if it
> works, commit.

I've fixed that in my last CR already. I will give it a final test and commit
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b