Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5725)

Issue 24600043: Fix bundle services stacked in the topology.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by frankban
Modified:
10 years, 5 months ago
Reviewers:
mp+194735
Visibility:
Public.

Description

Fix bundle services stacked in the topology. QA: Execute the following: - (sudo) juju bootstrap --debug - juju deploy juju-gui - juju expose juju-gui - juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/bug-1249051-service-positions When the gui is ready, drag and drop the bundle in https://launchpadlibrarian.net/156058100/export%20%285%29.yaml The services should be correctly deployed and both visible. https://code.launchpad.net/~frankban/juju-gui/bug-1249051-service-positions/+merge/194735 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix bundle services stacked in the topology. #

Patch Set 3 : Fix bundle services stacked in the topology. #

Patch Set 4 : Fix bundle services stacked in the topology. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -7 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +6 lines, -1 line 0 comments Download
M app/views/topology/topology.js View 1 chunk +11 lines, -5 lines 0 comments Download
M app/views/topology/utils.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_topology.js View 1 chunk +26 lines, -0 lines 0 comments Download
M test/test_topology_utils.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 5 months ago (2013-11-11 18:18:48 UTC) #1
bac
LGMT and the QA was good. I was a little surprised the relation was added ...
10 years, 5 months ago (2013-11-11 19:56:53 UTC) #2
frankban
*** Submitted: Fix bundle services stacked in the topology. QA: Execute the following: - (sudo) ...
10 years, 5 months ago (2013-11-12 09:08:21 UTC) #3
frankban
10 years, 5 months ago (2013-11-12 09:13:26 UTC) #4
On 2013/11/11 19:56:53, bac wrote:
> LGMT and the QA was good.

Thank you Brad!

> I was a little surprised the relation was added very late but it did
eventually
> show up.  (Completely incidental to this branch, of course.)

That's how the deployer works: it waits for the units to be ready before adding
relations.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b