Issue 245850043: fix failing lxml based docbook tests, partially fix 369

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 245850043: fix failing lxml based docbook tests, partially fix 369 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by RogerHaase

Modified:
8 years, 10 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

fix failing lxml based docbook tests, partially fix #369

Patch Set 1 #

Total comments: 3

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	MoinMoin/converter/_tests/test_docbook_in.py	View		4 chunks	+19 lines, -12 lines	2 comments	Download
	M	MoinMoin/converter/docbook_in.py	View		2 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

RogerHaase

8 years, 10 months ago (2015-06-12 16:06:12 UTC) #1

https://codereview.appspot.com/245850043/diff/40001/MoinMoin/converter/_tests...
File MoinMoin/converter/_tests/test_docbook_in.py (right):

https://codereview.appspot.com/245850043/diff/40001/MoinMoin/converter/_tests...
MoinMoin/converter/_tests/test_docbook_in.py:342:
'/page/body/div/div[@html:class="db-mediaobject"]/span/object[@xlink:href="+get/figures/eiffeltower.png"][@type="image/png"]'),
above tests were just missing +get/

https://codereview.appspot.com/245850043/diff/40001/MoinMoin/converter/_tests...
MoinMoin/converter/_tests/test_docbook_in.py:409:
u'/page/body/div/p/span[@html:class="db-trademark"][text()="Foo Bar\u2122"]'),
added tests for other types of trademarks

https://codereview.appspot.com/245850043/diff/40001/MoinMoin/converter/docboo...
File MoinMoin/converter/docbook_in.py (right):

https://codereview.appspot.com/245850043/diff/40001/MoinMoin/converter/docboo...
MoinMoin/converter/docbook_in.py:986: 'registered': u'\xae',  # u'&reg;',
changed to \x.. to be consistent with tests

Expand All Messages | Collapse All Messages