Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6620)

Issue 245430043: Parentheses in ChordNames have the same size as the Chord symbols.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by marc
Modified:
8 years, 10 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Parentheses in ChordNames have the same size as the Chord symbols.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2
dak
https://codereview.appspot.com/245430043/diff/1/ly/engraver-init.ly File ly/engraver-init.ly (right): https://codereview.appspot.com/245430043/diff/1/ly/engraver-init.ly#newcode517 ly/engraver-init.ly:517: \override ParenthesesItem.font-size = #1.5 Well, it's awkward to have ...
8 years, 10 months ago (2015-06-21 08:43:54 UTC) #1
marc
8 years, 10 months ago (2015-06-21 08:54:16 UTC) #2
Am 21.06.2015 um 10:43 schrieb dak@gnu.org:
>
> https://codereview.appspot.com/245430043/diff/1/ly/engraver-init.ly
> File ly/engraver-init.ly (right):
>
>
https://codereview.appspot.com/245430043/diff/1/ly/engraver-init.ly#newcode517
>
> ly/engraver-init.ly:517: \override ParenthesesItem.font-size = #1.5
> Well, it's awkward to have parentheses sized independently from their
> content.  The default size is probably intended to fit between staff
> lines.  In that case, it might make sense to increase the size for
> TabStaff with its larger staffline spacing as well?

Well, the tablature/parentheses stuff is in a inconsistent state anyway.
Tied notes (fret numbers) have whiteout, \parenthesize'd notes don't.
>
> In a ChordNames context, I could not think of stuff that is easily
> parenthesized other than the chord names themselves.  While it is
> perfectly conceivable to write something like C(7), I don't see any way
> where one would have a reasonable chance to use a working parenthesize
> property on anything but the main chord name.  So increasing the size
> here seems without tangible drawbacks.

Ok.

> No idea about the nicest size for FiguredBass though.
>
> Executive summary: this change is likely a good idea, some others might
> independently be nice.

If time allows, I'll have a look.

Thanks,

Marc
>
> https://codereview.appspot.com/245430043/
>

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b