Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 244440043: Multiqueue support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by Pasquale Imputato
Modified:
2 years, 3 months ago
Reviewers:
S. Deronne, riley, Stefano Avallone, Vedran Miletić, tomh
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Multiqueue support

Patch Set 1 : Tom's aqm work #

Patch Set 2 : Netdevices can return the number of trasmission queues #

Patch Set 3 : Introduce a Queue Tag to allow devices to select the tx queue #

Patch Set 4 : IsStopped and priority queue control #

Patch Set 5 : Wake callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -19 lines) Patch
M src/internet/model/ipv4-interface.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-interface.cc View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M src/internet/model/priority-queue.h View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M src/internet/model/priority-queue.cc View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M src/network/model/net-device.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/point-to-point/model/point-to-point-net-device.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/point-to-point/model/point-to-point-net-device.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/wifi/model/dca-txop.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M src/wifi/model/dca-txop.cc View 1 2 3 4 3 chunks +20 lines, -1 line 0 comments Download
M src/wifi/model/edca-txop-n.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M src/wifi/model/edca-txop-n.cc View 1 2 3 4 3 chunks +20 lines, -1 line 0 comments Download
M src/wifi/model/regular-wifi-mac.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.cc View 1 2 3 4 2 chunks +33 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mac.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-net-device.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/wifi/model/wifi-net-device.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Pasquale Imputato
This is our attempt at adding support for multiqueue netdevices (such as WiFi) in ns-3, ...
3 years, 1 month ago (2015-06-22 14:48:41 UTC) #1
Pasquale Imputato
Hi, our updated approach is in [1]. Any comment/review of the code would be much ...
2 years, 8 months ago (2015-11-24 09:02:38 UTC) #2
tomh_tomh.org
On 11/24/2015 01:02 AM, p.imputato@gmail.com wrote: > Hi, > our updated approach is in [1]. ...
2 years, 8 months ago (2015-11-24 18:02:33 UTC) #3
Pasquale Imputato
2 years, 8 months ago (2015-11-25 22:32:23 UTC) #4
2015-11-24 19:02 GMT+01:00 Tom Henderson <tomh@tomh.org>:

> On 11/24/2015 01:02 AM, p.imputato@gmail.com wrote:
>
>> Hi,
>> our updated approach is in [1].
>> Any comment/review of the code would be much appreciated.
>>
>> [1] https://github.com/stavallo/ns-3-dev-git/commits/traffic-control
>>
>> https://codereview.appspot.com/244440043/
>>
>
> Hi, can you provide a bit more background?
>
> - should the codereview be disregarded at this time?  (the github code is
> newer)
>

Hi Tom,

this work has been announced on the ns-developers mailing list by Stefano
Avallone.
The codereview can be disregarded; the github code provides a refinement of
the design of traffic-control and queue disc in ns-3.


>
> - are there any open issues or things you wish to call out to people
> regarding the code?


We ask a general comment/review about the work in order to define future
directions.

Open issue are:

- how to render qdisc_reschedule in ns-3. When dequeue operations are
stopped, Linux reschedules the qdisc (i.e., a qdisc_run will be invoked as
soon as the cpu can schedule it). For the moment, we do nothing in place of
a reschedule call. A possibility would be to schedule a QueueDisc::Run
after a predefined amount of time, but we are not sure yet how to set such
amount of time

- we would like the NetDevice base class to allocate the array used to
track the status of each transmission queue. However, each derived class
has to specify the number of physical tx queues at construction time. Can
we use the DoInitialize method to achieve this goal? For instance, the
NetDevice base class has a protected member m_numTxQueues;
WifiNetDevice::DoInitialize sets m_numTxQueues to 4; then
NetDevice::DoInitialize allocates, e.g., a vector of 4 boolean value


> Is there a good example program that we can try it out with?
>

A simple example that show how use TrafficContorlHelper has been added to
the branch and is in examples/traffic-control.


>
> Thanks,
> Tom
>

Thanks,

-- 
Pasquale Imputato
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b