Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13407)

Issue 243250043: Remove a _lot_ of parser/(*parser*) function arguments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by dak
Modified:
8 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove a _lot_ of parser/(*parser*) function arguments This is a bit uglified because it is likely going to become part of version 2.19.23 or later, so this proactively bumps the version. The final committed version will just be what is in master at that time. Contains the following commits in reverse order: Bump version for the sake of regtesting Fix the rest of removal of parser/(*parser*) manually Call all *-handler functions without parser argument Let ly:parse-error and others work with %parser fluid Run scripts/auxiliar/update-with-convert-ly.sh, convert scm as well convert-ly rule for removing parser/(*parser*) from various function calls

Patch Set 1 #

Patch Set 2 : Various rule improvements and fixes #

Patch Set 3 : Simplify #{ #} as well #

Patch Set 4 : Explain general removal of "parser" in Changes #

Patch Set 5 : Stop maintaining "parser" variable, update CG example code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -517 lines) Patch
M Documentation/changes.tely View 1 2 3 1 chunk +14 lines, -11 lines 0 comments Download
M Documentation/contributor/programming-work.itexi View 1 2 3 4 1 chunk +8 lines, -9 lines 0 comments Download
M Documentation/cs/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/hu/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/clip-systems.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/generating-whole-scores-also-book-parts-in-scheme-without-using-the-parser.ly View 6 chunks +22 lines, -24 lines 0 comments Download
M Documentation/usage/lilypond-book.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M VERSION View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/backend-svg.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/clip-systems.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/display-lily-tests.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/general-scheme-bindings.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/include-string.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/note-names.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/optional-args-backup.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/optional-args-predicate.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/scheme-book-scores.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M lily/lily-parser.cc View 1 2 3 4 4 chunks +3 lines, -12 lines 0 comments Download
M lily/lily-parser-scheme.cc View 5 chunks +58 lines, -51 lines 0 comments Download
M lily/parse-scm.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M lily/parser.yy View 10 chunks +17 lines, -19 lines 0 comments Download
M ly/articulate.ly View 4 chunks +6 lines, -6 lines 0 comments Download
M ly/bagpipe.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/base-tkit.ly View 3 chunks +4 lines, -4 lines 0 comments Download
M ly/chord-repetition-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/declarations-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/graphviz-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/init.ly View 4 chunks +9 lines, -9 lines 0 comments Download
M ly/makam.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 22 chunks +25 lines, -30 lines 0 comments Download
M ly/property-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/string-tunings-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +58 lines, -0 lines 0 comments Download
M scm/autochange.scm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scm/define-music-display-methods.scm View 41 chunks +159 lines, -163 lines 0 comments Download
M scm/define-note-names.scm View 2 chunks +2 lines, -2 lines 0 comments Download
M scm/display-lily.scm View 3 chunks +3 lines, -3 lines 0 comments Download
M scm/lily-library.scm View 4 chunks +56 lines, -62 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 2 chunks +2 lines, -3 lines 0 comments Download
M scm/music-functions.scm View 8 chunks +30 lines, -37 lines 0 comments Download
M scm/paper.scm View 1 1 chunk +1 line, -2 lines 0 comments Download
M scm/parser-ly-from-scheme.scm View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M scm/part-combiner.scm View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
dak
Various rule improvements and fixes
8 years, 10 months ago (2015-06-11 21:00:00 UTC) #1
dak
Simplify #{ #} as well
8 years, 10 months ago (2015-06-11 21:08:36 UTC) #2
dak
Explain general removal of "parser" in Changes
8 years, 10 months ago (2015-06-12 10:22:20 UTC) #3
dak
(define (print-book-with book process-procedure)
8 years, 10 months ago (2015-06-12 12:29:46 UTC) #4
dak
8 years, 10 months ago (2015-06-12 12:31:35 UTC) #5
On 2015/06/12 12:29:46, dak wrote:
> (define (print-book-with book process-procedure)

Uh, bad clipboard content.  This was supposed to be:

Stop maintaining "parser" variable, update CG example code
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b