Automation + Global History

#ChangeLog from patch #2
Fixed the alignment of sub menu tabs and item views tabs
Added active visual effect to the current tab view
Fixed horizontal scroll bug
Fixed padding inside sub menu
Increased font size for wiki contents

Automation + Global History
# Changelog 3 , new cr patch 1
Added automation. run `$ ./m css ` to automatically compile all the less files.
Modernized theme now runs with the current version of xstatic bootstrap.
Rewrote `global history` template
Changed font sizes at various places

Changelog #4
Made changes as suggested in last CR

ChangeLog #5
Created a special directory exclusively for modernized theme's template.
Added footer and breadcrumb.
Made changes as suggested by mentors in previous patch

[yask123, 2015-06-18 21:59:16]

https://codereview.appspot.com/242460043/diff/1/MoinMoin/static/js/common.js
File MoinMoin/static/js/common.js (right):

https://codereview.appspot.com/242460043/diff/1/MoinMoin/static/js/common.js#...
MoinMoin/static/js/common.js:24: list = $('.moin-panel'),
Because .panel interfered with Bootstrap's default .panel class

https://codereview.appspot.com/242460043/diff/1/MoinMoin/templates/base.html
File MoinMoin/templates/base.html (right):

https://codereview.appspot.com/242460043/diff/1/MoinMoin/templates/base.html#...
MoinMoin/templates/base.html:55: 
Removed common.css so that it doesn't interfere with my custom theme.

[ajgupta93, 2015-06-20 16:19:23]

On 2015/06/18 21:59:16, yask123 wrote:
> https://codereview.appspot.com/242460043/diff/1/MoinMoin/static/js/common.js
> File MoinMoin/static/js/common.js (right):
> 
>
https://codereview.appspot.com/242460043/diff/1/MoinMoin/static/js/common.js#...
> MoinMoin/static/js/common.js:24: list = $('.moin-panel'),
> Because .panel interfered with Bootstrap's default .panel class
> 
> https://codereview.appspot.com/242460043/diff/1/MoinMoin/templates/base.html
> File MoinMoin/templates/base.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/1/MoinMoin/templates/base.html#...
> MoinMoin/templates/base.html:55: 
> Removed common.css so that it doesn't interfere with my custom theme.

looks ok to me

[ajgupta93, 2015-06-20 16:48:49]

https://codereview.appspot.com/242460043/diff/20001/MoinMoin/templates/layout...
File MoinMoin/templates/layout.html (right):

https://codereview.appspot.com/242460043/diff/20001/MoinMoin/templates/layout...
MoinMoin/templates/layout.html:108: {% block header_itemviews %}{% endblock %}
use 2 different lines for these. indentation looks better that way

https://codereview.appspot.com/242460043/diff/20001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/theme.less (right):

https://codereview.appspot.com/242460043/diff/20001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/theme.less:55: .set-bookmark-btn{
probably add '.moin-'to these selectors

https://codereview.appspot.com/242460043/diff/20001/make.py
File make.py (right):

https://codereview.appspot.com/242460043/diff/20001/make.py#newcode386
make.py:386: command1 = 'cd {0}{1}lessc {2} theme.less
../css/theme.css'.format(modernized_loc, SEP, include)
rather change this to command_basic and command_modernized

[RogerHaase, 2015-06-22 16:08:30]

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
File MoinMoin/templates/forms.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
MoinMoin/templates/forms.html:23: {{ gen.input(type='submit',
value=form.submit_label, class='btn btn-primary', **kwargs) }}
you make all future themes dependent upon bootstrap? imho, a bad idea.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
File MoinMoin/templates/global_history.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
MoinMoin/templates/global_history.html:16: <div class="container">
same objection to making all future themes dependent on bootstrap. Themes should
define header, sidebar, footer.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/itemvi...
File MoinMoin/templates/itemviews.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/itemvi...
MoinMoin/templates/itemviews.html:2: <ul class="nav nav-tabs moin-panel">
ditto

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
File MoinMoin/templates/layout.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
MoinMoin/templates/layout.html:14: <div class="container">
ditto

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
File MoinMoin/templates/modify.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
MoinMoin/templates/modify.html:33: <span class="fa fa-download"></span> {{
_('Download') }}</a>
indent and put </a> on next line for clarity

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/theme.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/theme.css:1: /*! normalize.css v3.0.0 |
MIT License | git.io/normalize */
put back the DO NOT EDIT THIS FILE warning. It is not nice to delete
JuergenHermann's copyright.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/theme.css:182: @media print {
userstyles missing?

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/normalize.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/normalize.css:1: /*! normalize.css
v3.0.0 | MIT License | git.io/normalize */
This file is not needed here. normalize.less is distributed with Bootstrap.
Compile similar to the way basic does it.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/theme.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/theme.less:2: // Yask Srivastava
if you are trying to make a copyright, follow conventions in other files

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/theme.less:9: @import
"normalize.less";
here normalize.less is imported, so normalize.css file is not needed

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/variables2.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/variables2.less:2: //
--------------------------------------------------
why not use moin-variables.less like basic theme. Why is this so large compared
to basic version?

https://codereview.appspot.com/242460043/diff/60001/make.py
File make.py (right):

https://codereview.appspot.com/242460043/diff/60001/make.py#newcode364
make.py:364: """run Stylus and lessc to update CSS files"""
remove stylus reference

https://codereview.appspot.com/242460043/diff/60001/make.py#newcode397
make.py:397: print 'Error: Modernized theme CSS files update failed, see error
messages above.'
a nit, but you could save a few lines of code by making a loop

for command, theme in ((a, x), (b, y)):

https://codereview.appspot.com/242460043/diff/60001/make.py#newcode399
make.py:399: 
pep8 error shows you forgot to run tests

[waldi, 2015-06-23 09:06:43]

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/theme.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/theme.css:1: /*! normalize.css v3.0.0 |
MIT License | git.io/normalize */
On 2015/06/22 16:08:29, RogerHaase wrote:
> put back the DO NOT EDIT THIS FILE warning. It is not nice to delete
> JuergenHermann's copyright.

Well, this file is not longer derived from him. The removal of the warning is
not nice indeed.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/modernized.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/modernized.less:5: @import
url("https://fonts.googleapis.com/css?family=Roboto:300,400,500,700");
What is the reason for this font include? Please move it into the file where it
is actually referenced.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/normalize.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/normalize.css:1: /*! normalize.css
v3.0.0 | MIT License | git.io/normalize */
You miss the complete license terms of this file

[yask123, 2015-06-23 15:20:28]

On 2015/06/22 16:08:30, RogerHaase wrote:
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
> File MoinMoin/templates/forms.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
> MoinMoin/templates/forms.html:23: {{ gen.input(type='submit',
> value=form.submit_label, class='btn btn-primary', **kwargs) }}
> you make all future themes dependent upon bootstrap? imho, a bad idea.
  I need to chat with you regarding this. The issue is for instance in this case
if I wish to use moin-button instead of `btn and btn-primary` , I would have to
use css inheritance by less which would increase the size of css file.

>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
> File MoinMoin/templates/global_history.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
> MoinMoin/templates/global_history.html:16: <div class="container">
> same objection to making all future themes dependent on bootstrap. Themes
should
> define header, sidebar, footer.
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/itemvi...
> File MoinMoin/templates/itemviews.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/itemvi...
> MoinMoin/templates/itemviews.html:2: <ul class="nav nav-tabs moin-panel">
> ditto
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
> File MoinMoin/templates/layout.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
> MoinMoin/templates/layout.html:14: <div class="container">
> ditto
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
> File MoinMoin/templates/modify.html (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
> MoinMoin/templates/modify.html:33: <span class="fa fa-download"></span> {{
> _('Download') }}</a>
> indent and put </a> on next line for clarity
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/css/theme.css (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/css/theme.css:1: /*! normalize.css v3.0.0 |
> MIT License | git.io/normalize */
> put back the DO NOT EDIT THIS FILE warning. It is not nice to delete
> JuergenHermann's copyright.
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/css/theme.css:182: @media print {
> userstyles missing?
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/custom-less/normalize.css (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/normalize.css:1: /*!
normalize.css
> v3.0.0 | MIT License | git.io/normalize */
> This file is not needed here. normalize.less is distributed with Bootstrap.
> Compile similar to the way basic does it.
Okkey!
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/custom-less/theme.less (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/theme.less:2: // Yask Srivastava
> if you are trying to make a copyright, follow conventions in other files
No , I dont wish to make copyright , I'll remove this.

>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/theme.less:9: @import
> "normalize.less";
> here normalize.less is imported, so normalize.css file is not needed
Yea! I I think this was created by mistake. I'll remove this.

>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/custom-less/variables2.less (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/variables2.less:2: //
> --------------------------------------------------
> why not use moin-variables.less like basic theme. Why is this so large
compared
> to basic version?
 The basic theme uses two variable files. variables.less and
moin-variables.less. Where as modernized them only uses variables2.less which
contains less number of lines compared to basic's variable files combined. In
Bootstrap variables.less file contains universal settings for a particular theme
eg: primary colour, text size.. etc. These settings are different for different
themes. So I edited Bootstrap's variable less file to make colour,size.. changes
to modernized theme.
> https://codereview.appspot.com/242460043/diff/60001/make.py
> File make.py (right):
> 
> https://codereview.appspot.com/242460043/diff/60001/make.py#newcode364
> make.py:364: """run Stylus and lessc to update CSS files"""
> remove stylus reference
Okkey!
> https://codereview.appspot.com/242460043/diff/60001/make.py#newcode397
> make.py:397: print 'Error: Modernized theme CSS files update failed, see error
> messages above.'
> a nit, but you could save a few lines of code by making a loop
> 
> for command, theme in ((a, x), (b, y)):
Okkey!
> https://codereview.appspot.com/242460043/diff/60001/make.py#newcode399
> make.py:399: 
> pep8 error shows you forgot to run tests
Okkey!

[yask123, 2015-06-23 15:22:24]

On 2015/06/23 09:06:43, waldi wrote:
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/css/theme.css (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/css/theme.css:1: /*! normalize.css v3.0.0 |
> MIT License | git.io/normalize */
> On 2015/06/22 16:08:29, RogerHaase wrote:
> > put back the DO NOT EDIT THIS FILE warning. It is not nice to delete
> > JuergenHermann's copyright.
> 
> Well, this file is not longer derived from him. The removal of the warning is
> not nice indeed.
Sorry! I'll add the copyright.
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/custom-less/modernized.less (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/modernized.less:5: @import
> url("https://fonts.googleapis.com/css?family=Roboto:300,400,500,700");
> What is the reason for this font include? Please move it into the file where
it
> is actually referenced.
Okkey!
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> File MoinMoin/themes/modernized/static/custom-less/normalize.css (right):
> 
>
https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
> MoinMoin/themes/modernized/static/custom-less/normalize.css:1: /*!
normalize.css
> v3.0.0 | MIT License | git.io/normalize */
> You miss the complete license terms of this file
I'll add it in next CR

[yask123, 2015-06-23 19:14:48]

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/theme.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/theme.css:182: @media print {
On 2015/06/22 16:08:29, RogerHaase wrote:
> userstyles missing?

Ooops! Adding them.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/variables2.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/variables2.less:2: //
--------------------------------------------------
On 2015/06/22 16:08:30, RogerHaase wrote:
> why not use moin-variables.less like basic theme. Why is this so large
compared
> to basic version?

If you notice basic theme imports `bootstrap.less` file and inside`
bootstrap.less` file we another import 'variables.less` whose size is similar to
the size of variables2.less.

variables.less files in bootstrap define specific colors , sizes , padding etc
which are different for different themes. Thats why I am using a different
variables.less file which was downloaded from Bootstrtap source and edited to
make exclusive changes for modernized theme.

You can compare the lines of css code generated after compiling basic's
theme.less and modernized's theme.less . 6874(basic) vs 3926 (modernized)

[yask123, 2015-06-24 00:38:58]

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
File MoinMoin/templates/forms.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/forms....
MoinMoin/templates/forms.html:23: {{ gen.input(type='submit',
value=form.submit_label, class='btn btn-primary', **kwargs) }}
On 2015/06/22 16:08:29, RogerHaase wrote:
> you make all future themes dependent upon bootstrap? imho, a bad idea.

I did as you said , for bootstrap template created themes/modernized/templates
directory and put it there.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
File MoinMoin/templates/global_history.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/global...
MoinMoin/templates/global_history.html:16: <div class="container">
On 2015/06/22 16:08:29, RogerHaase wrote:
> same objection to making all future themes dependent on bootstrap. Themes
should
> define header, sidebar, footer.

I transferred this template to theme specific template folder.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
File MoinMoin/templates/layout.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/layout...
MoinMoin/templates/layout.html:14: <div class="container">
On 2015/06/22 16:08:29, RogerHaase wrote:
> ditto

I transferred this template to theme specific template folder.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
File MoinMoin/templates/modify.html (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/templates/modify...
MoinMoin/templates/modify.html:33: <span class="fa fa-download"></span> {{
_('Download') }}</a>
On 2015/06/22 16:08:29, RogerHaase wrote:
> indent and put </a> on next line for clarity

done

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/theme.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/theme.css:1: /*! normalize.css v3.0.0 |
MIT License | git.io/normalize */
On 2015/06/22 16:08:29, RogerHaase wrote:
> put back the DO NOT EDIT THIS FILE warning. It is not nice to delete
> JuergenHermann's copyright.

Done

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/modernized.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/modernized.less:5: @import
url("https://fonts.googleapis.com/css?family=Roboto:300,400,500,700");
On 2015/06/23 09:06:43, waldi wrote:
> What is the reason for this font include? Please move it into the file where
it
> is actually referenced.

Modernized theme uses Roboto fonts.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/normalize.css (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/normalize.css:1: /*! normalize.css
v3.0.0 | MIT License | git.io/normalize */
On 2015/06/22 16:08:30, RogerHaase wrote:
> This file is not needed here. normalize.less is distributed with Bootstrap.
> Compile similar to the way basic does it.

Removed

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/custom-less/theme.less (right):

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/theme.less:2: // Yask Srivastava
On 2015/06/22 16:08:30, RogerHaase wrote:
> if you are trying to make a copyright, follow conventions in other files

Nopes. I removed it.

https://codereview.appspot.com/242460043/diff/60001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/custom-less/theme.less:9: @import
"normalize.less";
On 2015/06/22 16:08:30, RogerHaase wrote:
> here normalize.less is imported, so normalize.css file is not needed

Yep , I removed normalize.css file. It was created by mistake in my machine.

https://codereview.appspot.com/242460043/diff/60001/make.py
File make.py (right):

https://codereview.appspot.com/242460043/diff/60001/make.py#newcode399
make.py:399: 
On 2015/06/22 16:08:30, RogerHaase wrote:
> pep8 error shows you forgot to run tests

Fixed it.

[RogerHaase, 2015-06-24 15:02:03]

I cloned your repo and applied this patch. ./m coding-std shows 2 new flags (a
third is fixed in my repo, but you can fix as well). ./m tests run without
errors :)

One HTML validation error on Home page. Several HTML validation errors on Global
History and Global Index.

Header looks odd at 1980 pixel width - there is a big Submit button related to
search. At ~800 pixel width, header breaks with lots of overlaid elements.

Text of logos in footer in nearly invisible.

I repeat my suggestion of reducing the size of this patch by moving index.html
and global_history.html (maybe utils.html) to a separate patch.