Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)

Issue 242420043: i#1709 Add README.md files to facilitate GitHub browsing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by Byron
Modified:
10 years, 9 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1709 Add README.md files to facilitate GitHub browsing Adding a README.md file in every top-level directory, and every sub-directory having a dedicated page in the API documentation. Fixes #1709 ---------------

Patch Set 1 #

Total comments: 13

Patch Set 2 : Changes per code review #

Patch Set 3 : Changed to inline link style #

Patch Set 4 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A api/docs/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A api/samples/README.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A clients/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A clients/drcov/README.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A clients/drltrace/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A core/README.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A ext/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ext/drcontainers/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ext/drgui/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ext/drmgr/README.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ext/drsyms/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ext/drutil/README.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ext/drwrap/README.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ext/drx/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A libutil/README.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A make/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A suite/README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/README.md View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Byron
10 years, 9 months ago (2015-06-17 19:37:31 UTC) #1
bruening
I'm curious: why the footnote style instead of inlined links? I would think inlined would ...
10 years, 9 months ago (2015-06-18 21:56:26 UTC) #2
Byron
Commit log for latest patchset: --------------- i#1709 Add README.md files to facilitate GitHub browsing Adding ...
10 years, 9 months ago (2015-06-18 23:47:54 UTC) #3
Byron
https://codereview.appspot.com/242420043/diff/1/api/docs/README.md File api/docs/README.md (right): https://codereview.appspot.com/242420043/diff/1/api/docs/README.md#newcode4 api/docs/README.md:4: [1]: http://dynamorio.org/docs/index.html On 2015/06/18 21:56:25, bruening wrote: > IMHO ...
10 years, 9 months ago (2015-06-18 23:48:17 UTC) #4
bruening
https://codereview.appspot.com/242420043/diff/1/api/docs/README.md File api/docs/README.md (right): https://codereview.appspot.com/242420043/diff/1/api/docs/README.md#newcode4 api/docs/README.md:4: [1]: http://dynamorio.org/docs/index.html On 2015/06/18 23:48:16, Byron wrote: > On ...
10 years, 9 months ago (2015-06-26 15:01:46 UTC) #5
Byron
Commit log for latest patchset: --------------- i#1709 Add README.md files: added README.md files Added a ...
10 years, 9 months ago (2015-06-26 15:49:47 UTC) #6
bruening
LGTM
10 years, 9 months ago (2015-06-26 20:06:43 UTC) #7
Byron
10 years, 9 months ago (2015-06-26 20:42:54 UTC) #8
Committed as
https://github.com/DynamoRIO/dynamorio/commit/a729fe43f9faa2c2018c07943ca0317...

Final commit log: 
---------------
i#1709 Add README.md files: added README.md files

Added a README.md file in every top-level directory, and every
sub-directory having a dedicated page in the API documentation,
to facilitate browsing on github.

Fixes #1709

Review-URL: https://codereview.appspot.com/242420043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b