Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 241340043: Define default fonts in fontconfig configuration file

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by trueroad
Modified:
8 years, 9 months ago
Reviewers:
pkx166h, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Define default fonts in fontconfig configuration file This commit defines LilyPond default fonts in local fontconfig configuration file. And, LilyPond uses them. It is possible to combine multiple fonts with different character sets and glyphs each other. e.g. Following fonts can be combined. Latin glyphs: from a font without Cyrillic glyphs Cyrillic glyphs: from another font with Cyrillic glyphs Add local fontconfig configuration file loading This commit becomes that LilyPond local (dedicated) fontconfig configuration file `fonts/lilypond-fonts.conf' can be used.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary loop and add reject bitmap fonts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -21 lines) Patch
M GNUmakefile.in View 1 chunk +3 lines, -1 line 0 comments Download
M lily/font-config.cc View 1 1 chunk +17 lines, -12 lines 0 comments Download
M mf/GNUmakefile View 3 chunks +8 lines, -2 lines 0 comments Download
A mf/lilypond-fonts.conf.in View 1 1 chunk +54 lines, -0 lines 0 comments Download
M scm/font.scm View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9
pkx166h
Passes make, make check and a full make doc.
8 years, 9 months ago (2015-06-11 16:05:50 UTC) #1
lemzwerg
Nice! LGTM. https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode60 lily/font-config.cc:60: confs.push_back (lilypond_datadir + "/fonts/lilypond-fonts.conf"); This line adds ...
8 years, 9 months ago (2015-06-11 22:12:33 UTC) #2
lemzwerg
https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode62 lily/font-config.cc:62: for (vsize i = 0; i < confs.size (); ...
8 years, 9 months ago (2015-06-11 22:14:32 UTC) #3
trueroad
https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode62 lily/font-config.cc:62: for (vsize i = 0; i < confs.size (); ...
8 years, 9 months ago (2015-06-11 23:23:04 UTC) #4
trueroad
Remove unnecessary loop and add reject bitmap fonts
8 years, 9 months ago (2015-06-12 10:56:34 UTC) #5
trueroad
I've improved and uploaded the patch. Issue 4441 / 5: Reject bitmap fonts in lilypond-fonts.conf ...
8 years, 9 months ago (2015-06-12 11:02:03 UTC) #6
trueroad
Would you change this issue 4441's labels? I don't have permission to edit issue. git-cl ...
8 years, 9 months ago (2015-06-12 11:07:08 UTC) #7
lemzwerg
LGTM, thanks!
8 years, 9 months ago (2015-06-12 23:14:18 UTC) #8
trueroad
8 years, 9 months ago (2015-06-17 10:57:59 UTC) #9
I've pushed to staging.

Issue 4441  / 1: Remove unnecessary loop
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 12 Jun 2015 07:12:43 +0000 (16:12 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Wed, 17 Jun 2015 10:47:09 +0000 (19:47 +0900)
commit    e3246bd7dd2cb83f203dabcb43b988507ba715a7

Issue 4441  / 2: Add local fontconfig configuration file loading
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 12 Jun 2015 07:23:37 +0000 (16:23 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Wed, 17 Jun 2015 10:47:09 +0000 (19:47 +0900)
commit    6831c973d078b4e41025c27b725887028aff3e73

Issue 4441  / 3: Add empty lilypond-fonts.conf
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 12 Jun 2015 07:29:54 +0000 (16:29 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Wed, 17 Jun 2015 10:47:10 +0000 (19:47 +0900)
commit    0c3ccff5943a1b5cfea65f695b87a8d2262e0f97

Issue 4441  / 4: Define default fonts in fontconfig configuration file
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 12 Jun 2015 08:17:56 +0000 (17:17 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Wed, 17 Jun 2015 10:47:10 +0000 (19:47 +0900)
commit    28f58ecc2271956e9377dc61e5135ce3ade4abbd

Issue 4441  / 5: Reject bitmap fonts in lilypond-fonts.conf
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 12 Jun 2015 08:24:07 +0000 (17:24 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Wed, 17 Jun 2015 10:47:10 +0000 (19:47 +0900)
commit    3527336fc0bbb7c00f1d040420d4f2b1df8a3c38
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b