Issue 240820043: Use GLib.Idle.add() when ibus-engine-simple loads compose tables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 240820043: Use GLib.Idle.add() when ibus-engine-simple loads compose tables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by fujiwara

Modified:
8 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Use GLib.Idle.add() when ibus-engine-simple loads compose tables TEST=engine/ibus-engine-simple

Patch Set 2 : Updated with message #2. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
M	engine/Makefile.am	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	engine/main.vala	View	1	1 chunk	+32 lines, -27 lines	0 comments	Download
M	src/ibuscomposetable.c	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ibusenginesimple.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/240820043/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/240820043/diff/1/engine/main.vala#newcode55 engine/main.vala:55: GLib.Idle.add(() => { Could you please add more ...

8 years, 11 months ago (2015-05-19 13:49:24 UTC) #2

fujiwara

https://codereview.appspot.com/240820043/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/240820043/diff/1/engine/main.vala#newcode55 engine/main.vala:55: GLib.Idle.add(() => { On 2015/05/19 13:49:23, Peng wrote: > ...

8 years, 11 months ago (2015-05-20 03:25:58 UTC) #3

lgtm

Expand All Messages | Collapse All Messages