Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4470)

Issue 240820043: Use GLib.Idle.add() when ibus-engine-simple loads compose tables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by fujiwara
Modified:
9 years, 6 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Use GLib.Idle.add() when ibus-engine-simple loads compose tables TEST=engine/ibus-engine-simple

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M engine/Makefile.am View 1 chunk +0 lines, -1 line 0 comments Download
M engine/main.vala View 1 1 chunk +32 lines, -27 lines 0 comments Download
M src/ibuscomposetable.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/ibusenginesimple.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
fujiwara
9 years, 6 months ago (2015-05-19 10:46:04 UTC) #1
Peng
lgtm https://codereview.appspot.com/240820043/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/240820043/diff/1/engine/main.vala#newcode55 engine/main.vala:55: GLib.Idle.add(() => { Could you please add more ...
9 years, 6 months ago (2015-05-19 13:49:24 UTC) #2
fujiwara
https://codereview.appspot.com/240820043/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/240820043/diff/1/engine/main.vala#newcode55 engine/main.vala:55: GLib.Idle.add(() => { On 2015/05/19 13:49:23, Peng wrote: > ...
9 years, 6 months ago (2015-05-20 03:25:58 UTC) #3
Peng
9 years, 6 months ago (2015-05-20 20:08:27 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b