Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4258)

Issue 2408042: Ns-3 BulkSendApplication (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by Josh Pelkey
Modified:
10 years, 5 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com, riley_ece.gatech.edu
Visibility:
Public.

Description

BulkSendApplication sends data as fast as possible up to MaxBytes or unlimited if MaxBytes is zero. Think OnOff, but without the "off" and without the variable data rate. This application could be used, for example, in examples/tcp/tcp-large-transfer, in place of all the code which manually sets up a socket and writes until the buffer is full, etc. The following patch is required for BulkSendApplication to work: http://codereview.appspot.com/3484041/

Patch Set 1 #

Total comments: 13

Patch Set 2 : Updates for comments #

Patch Set 3 : Implement SO_TYPE requirement #

Total comments: 4

Patch Set 4 : Comment fixes, update documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -0 lines) Patch
M RELEASE_NOTES View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A examples/tcp/tcp-bulk-send.cc View 3 1 chunk +135 lines, -0 lines 0 comments Download
M examples/tcp/wscript View 1 chunk +4 lines, -0 lines 0 comments Download
A src/applications/bulk-send/bulk-send-application.h View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A src/applications/bulk-send/bulk-send-application.cc View 1 2 3 1 chunk +224 lines, -0 lines 0 comments Download
A src/applications/bulk-send/wscript View 1 chunk +13 lines, -0 lines 0 comments Download
A src/helper/bulk-send-helper.h View 1 1 chunk +111 lines, -0 lines 0 comments Download
A src/helper/bulk-send-helper.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
M src/helper/wscript View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/wscript View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
Josh Pelkey
Also plan adding a test case to src/application/bulk-send-test-case.cc once we figure out the UDP issue. ...
10 years, 9 months ago (2010-10-12 16:50:31 UTC) #1
Tom Henderson
My high-level comments are that: 1) this is a needed app, would like to merge ...
10 years, 9 months ago (2010-10-13 04:47:48 UTC) #2
Josh Pelkey
1) We'd like to get this in as well 2) This is a confirmed issue ...
10 years, 9 months ago (2010-10-13 17:10:41 UTC) #3
Tom Henderson
I'd like to suggest a way forward for merging this application that does not involve ...
10 years, 9 months ago (2010-10-25 04:02:34 UTC) #4
Josh Pelkey
Tom, I implemented 1) here: http://codereview.appspot.com/3484041/ I plan to use this implementation and update BulkSend ...
10 years, 7 months ago (2010-12-06 21:10:25 UTC) #5
Josh Pelkey
Patch set 3 requires the SO_TYPE patch here: http://codereview.appspot.com/3484041/ Now, when a user attempts to ...
10 years, 7 months ago (2010-12-07 21:45:49 UTC) #6
Josh Pelkey
I forgot to update the release notes with these implementation details, but I will do ...
10 years, 7 months ago (2010-12-07 21:47:08 UTC) #7
Tom Henderson
A few last comments; I think this is ready to merge otherwise. http://codereview.appspot.com/2408042/diff/18001/examples/tcp/tcp-bulk-send.cc File examples/tcp/tcp-bulk-send.cc ...
10 years, 7 months ago (2010-12-08 23:32:15 UTC) #8
Josh Pelkey
10 years, 7 months ago (2010-12-09 16:42:17 UTC) #9
Documentation updated and change made for the TcpSocketFactory.

http://codereview.appspot.com/2408042/diff/18001/examples/tcp/tcp-bulk-send.cc
File examples/tcp/tcp-bulk-send.cc (right):

http://codereview.appspot.com/2408042/diff/18001/examples/tcp/tcp-bulk-send.c...
examples/tcp/tcp-bulk-send.cc:24: // - Tracing of queues and packet receptions
to file "tcp-bulk-send.tr"
On 2010/12/08 23:32:15, Tom Henderson wrote:
> and mention that pcap traces are being generated.

Done.

http://codereview.appspot.com/2408042/diff/18001/src/applications/bulk-send/b...
File src/applications/bulk-send/bulk-send-application.cc (right):

http://codereview.appspot.com/2408042/diff/18001/src/applications/bulk-send/b...
src/applications/bulk-send/bulk-send-application.cc:63: TypeIdValue
(UdpSocketFactory::GetTypeId ()),
On 2010/12/08 23:32:15, Tom Henderson wrote:
> should this default be TcpSocketFactory?

whoops, yes
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b