Ns-3 SO_TYPE

Implemented Socket::GetSockType() (analogous to getsockopt(SO_TYPE) in ns-3.


ipv4-raw-socket, ipv6-raw-socket, and packet-socket return SOCK_RAW

tcp-socket and nsc-tcp-socket return SOCK_STREAM

udp-socket returns SOCK_DGRAM

[Tom Henderson, 2010-12-07 05:53:01]

This looks fine to me; just one minor comment, to replace
NS_LOG_FUNCTION_NOARGS() with NS_LOG_FUNCTION (this).  The former is usually
reserved for static functions.  I would be also fine with not having these
getters return function log calls but I see that the rest of the setters/getters
return them.

[Josh Pelkey, 2010-12-07 21:04:33]

I removed logging from the getters.

On 2010/12/07 05:53:01, Tom Henderson wrote:
> This looks fine to me; just one minor comment, to replace
> NS_LOG_FUNCTION_NOARGS() with NS_LOG_FUNCTION (this).  The former is usually
> reserved for static functions.  I would be also fine with not having these
> getters return function log calls but I see that the rest of the
setters/getters
> return them.