Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(235)

Issue 240270043: Issue 4423: Part_combine_iterator: eliminate array of context handles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Dan Eble
Modified:
8 years, 11 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This review covers multiple commits. [1] Part_combine_iterator: move mmrest killing after child iteration Also limit mmrest killing to contexts that have just changed from being used to being unused. [2] Part_combine_iterator: create child iterators in parent context Add an initial split state to ensure that the first split-list entry, whatever it is, will redirect the outlets for the child iterators. [3] Part_combine_iterator: use NullVoice instead of Devnull This makes all outlets a kind of Voice. [4] Part_combine_iterator: eliminate array of context handles The Part_combine_iterator no longer creates or keeps alive the Voice contexts that it uses. make-directed-part-combine-music does it. When the Part_combine_iterator needs to redirect a child iterator, it finds the new Voice by name among the siblings of the current Voice.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -75 lines) Patch
M lily/part-combine-iterator.cc View 12 chunks +69 lines, -70 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +12 lines, -5 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
Here's the next battle in the war against the Part_combine_iterator. I haven't created a Google ...
8 years, 11 months ago (2015-05-28 11:47:02 UTC) #1
pkx166h
8 years, 11 months ago (2015-05-28 13:02:54 UTC) #2
On 2015/05/28 11:47:02, Dan Eble wrote:
> Here's the next battle in the war against the Part_combine_iterator.
> I haven't created a Google Code issue yet.

https://code.google.com/p/lilypond/issues/detail?id=4423
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b