Issue 240020043: Issue 4410: Part_combine_iterator: treat child iterators as a set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 240020043: Issue 4410: Part_combine_iterator: treat child iterators as a set (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by Dan Eble

Modified:
8 years, 10 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Allocate iterators for the two parts in an array instead of separate named members. Use loops where appropriate.

Patch Set 2 : const Context *c #

Total comments: 2

Patch Set 4 : rebase #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -51 lines)			Patch
	M	lily/part-combine-iterator.cc	View	1 2 3	10 chunks	+65 lines, -51 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dak

Sorry for the previous empty review: somehow my comment in it got lost. https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc File ...

8 years, 11 months ago (2015-05-22 07:41:43 UTC) #4

Dan Eble

https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc#newcode111 lily/part-combine-iterator.cc:111: iterators_[i]->quit (); On 2015/05/22 07:41:43, dak wrote: > You ...

8 years, 11 months ago (2015-05-22 12:46:36 UTC) #5

rebase

Expand All Messages | Collapse All Messages