Issue 239730043: ShadPython - 4 - Alexander Andrianov - FIVT

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 239730043: ShadPython - 4 - Alexander Andrianov - FIVT

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by lxndr.ndrnv

Modified:
8 years, 11 months ago

Reviewers:
shad.python

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : fixes #

Total comments: 3

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -0 lines)			Patch
M	config.txt	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	main.py	View	1 chunk	+199 lines, -0 lines	2 comments	Download
M	test_main.py	View	1 chunk	+29 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

shad.python

8 years, 11 months ago (2015-05-25 19:54:44 UTC) #1

нужно поправить по-мелочи и чтобы проходили юнит-тесты.

--
Григорий Носырев

https://codereview.appspot.com/239730043/diff/20001/main.py
File main.py (right):

https://codereview.appspot.com/239730043/diff/20001/main.py#newcode126
main.py:126: print("#", end=" ")
обозначения ячеек лучше вынести в константы чтобы их было удобнее поменять в
случае чего

https://codereview.appspot.com/239730043/diff/20001/main.py#newcode192
main.py:192: with open("stats.csv", "wb") as f:
не нужно явно прописывать имена файлов, лучше задавать их в конфиге

https://codereview.appspot.com/239730043/diff/20001/test_main.py
File test_main.py (right):

https://codereview.appspot.com/239730043/diff/20001/test_main.py#newcode1
test_main.py:1: import unittest
Юнит-тесты не запускаются

Traceback (most recent call last):
  File ".\test_main.py", line 29, in <module>
    unittest.main()
  File "C:\Python27\lib\unittest\main.py", line 94, in __init__
    self.parseArgs(argv)
  File "C:\Python27\lib\unittest\main.py", line 149, in parseArgs
    self.createTests()
  File "C:\Python27\lib\unittest\main.py", line 155, in createTests
    self.test = self.testLoader.loadTestsFromModule(self.module)
  File "C:\Python27\lib\unittest\loader.py", line 65, in loadTestsFromModule
    tests.append(self.loadTestsFromTestCase(obj))
  File "C:\Python27\lib\unittest\loader.py", line 56, in loadTestsFromTestCase
    loaded_suite = self.suiteClass(map(testCaseClass, testCaseNames))
TypeError: __init__() takes exactly 1 argument (2 given)

Expand All Messages | Collapse All Messages