Issue 238670043: Issue 4427: clean up finding & changing of contexts in C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 238670043: Issue 4427: clean up finding & changing of contexts in C++ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by Dan Eble

Modified:
8 years, 11 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

clean up finding & changing of contexts in C++ Combine the key feature of Change_iterator and Auto_change_iterator into a common function (favoring the logic of Change_iterator). Define functions for various context-search loops.

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -146 lines)			Patch
M	lily/accidental-engraver.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	lily/auto-change-iterator.cc	View	4 chunks	+6 lines, -55 lines	0 comments	Download
M	lily/change-iterator.cc	View	1 chunk	+43 lines, -51 lines	0 comments	Download
M	lily/context.cc	View	2 chunks	+43 lines, -3 lines	0 comments	Download
M	lily/grace-engraver.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	lily/include/change-iterator.hh	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lily/include/context.hh	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	lily/lyric-combine-music-iterator.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	lily/lyric-engraver.cc	View	1 chunk	+2 lines, -17 lines	0 comments	Download
M	lily/note-head-line-engraver.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages