Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(743)

Issue 238540043: Handle Juju GUI server port.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by frankban
Modified:
8 years, 11 months ago
Reviewers:
mp+260032, matthew.scott
Visibility:
Public.

Description

Handle Juju GUI server port. The Juju GUI charm can be configured to listen to customized ports (juju set juju-gui port=n). This branch adds to quickstart the ability to detect the port used by the GUI server, and therefore connect to the right WebSocket and Web URLs. Additionally handle the cases in which the GUI is run in non secure mode. Also add an option to deploy the GUI on a customized port directly using quickstart. Also add an hidden options (--gui-source) intended for development use only. This allows for building a specific GUI github branch (e.g. frankban/my-feature-branch or juju/develop) when installing the Juju GUI, and can be useful while coding/QAing GUI branches. Tests: `make check`. QA: - use the GUI as usual, to check for regressions: `devenv/bin/juju-quickstart`; - change the juju-gui port and secure mode: `juju set juju-gui port=4242 secure=false` - wait for the changes to take effect; - use quickstart again to check that insecure mode and customized ports are detected: `devenv/bin/juju-quickstart`; - destroy the environment; - use quickstart again to server the GUI develop branch on a customized port: `devenv/bin/juju-quickstart --gui-port 8000 --gui-source juju/develop`; - check that everything works correctly; - destroy the environment; - done, thank you! https://code.launchpad.net/~frankban/juju-quickstart/handle-gui-ports/+merge/260032 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Handle Juju GUI server port. #

Patch Set 3 : Handle Juju GUI server port. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+642 lines, -133 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M quickstart/app.py View 7 chunks +34 lines, -3 lines 0 comments Download
A quickstart/jujugui.py View 1 chunk +84 lines, -0 lines 0 comments Download
M quickstart/jujutools.py View 4 chunks +10 lines, -42 lines 0 comments Download
M quickstart/manage.py View 8 chunks +75 lines, -18 lines 0 comments Download
M quickstart/platform_support.py View 1 chunk +0 lines, -1 line 0 comments Download
M quickstart/tests/test_app.py View 11 chunks +93 lines, -13 lines 0 comments Download
M quickstart/tests/test_juju.py View 1 chunk +11 lines, -0 lines 0 comments Download
A quickstart/tests/test_jujugui.py View 1 chunk +123 lines, -0 lines 0 comments Download
M quickstart/tests/test_jujutools.py View 6 chunks +47 lines, -48 lines 0 comments Download
M quickstart/tests/test_manage.py View 7 chunks +125 lines, -7 lines 0 comments Download
M quickstart/tests/test_utils.py View 1 chunk +23 lines, -0 lines 0 comments Download
M quickstart/utils.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
8 years, 11 months ago (2015-05-25 08:08:25 UTC) #1
frankban
Please take a look. https://codereview.appspot.com/238540043/diff/1/quickstart/jujugui.py File quickstart/jujugui.py (right): https://codereview.appspot.com/238540043/diff/1/quickstart/jujugui.py#newcode59 quickstart/jujugui.py:59: def parse_charm_url(charm_url): This function was ...
8 years, 11 months ago (2015-05-25 08:12:32 UTC) #2
matthew.scott
LGTM QA okay! Thanks for the work on this
8 years, 11 months ago (2015-05-25 15:45:56 UTC) #3
frankban
8 years, 11 months ago (2015-05-25 16:40:58 UTC) #4
*** Submitted:

Handle Juju GUI server port.

The Juju GUI charm can be configured to listen
to customized ports (juju set juju-gui port=n).
This branch adds to quickstart the ability to
detect the port used by the GUI server, and
therefore connect to the right WebSocket and
Web URLs. Additionally handle the cases in which
the GUI is run in non secure mode.

Also add an option to deploy the GUI on a
customized port directly using quickstart.

Also add an hidden options (--gui-source)
intended for development use only. This allows
for building a specific GUI github branch
(e.g. frankban/my-feature-branch or juju/develop)
when installing the Juju GUI, and can be useful
while coding/QAing GUI branches.

Tests: `make check`.

QA:
- use the GUI as usual, to check for regressions:
  `devenv/bin/juju-quickstart`;
- change the juju-gui port and secure mode:
  `juju set juju-gui port=4242 secure=false`
- wait for the changes to take effect;
- use quickstart again to check that insecure mode
  and customized ports are detected:
  `devenv/bin/juju-quickstart`;
- destroy the environment;
- use quickstart again to server the GUI develop
  branch on a customized port:
  `devenv/bin/juju-quickstart --gui-port 8000 --gui-source juju/develop`;
- check that everything works correctly;
- destroy the environment;
- done, thank you!

R=
CC=
https://codereview.appspot.com/238540043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b