Issue 23820043: code review 23820043: go.tools/go/types, cmd/gotype: fix early bailout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23820043: code review 23820043: go.tools/go/types, cmd/gotype: fix early bailout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by gri

Modified:
12 years, 4 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types, cmd/gotype: fix early bailout Clients must have chance to look at panics they are raising.

Patch Set 2 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 5 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	cmd/gotype/gotype.go	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	go/types/check.go	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 4 months ago (2013-11-08 20:47:39 UTC) #1

adonovan

LGTM https://codereview.appspot.com/23820043/diff/60001/go/types/check.go File go/types/check.go (right): https://codereview.appspot.com/23820043/diff/60001/go/types/check.go#newcode176 go/types/check.go:176: panic(p) Great! I have long disliked the fact ...

12 years, 4 months ago (2013-11-08 20:50:27 UTC) #2

gri

12 years, 4 months ago (2013-11-08 20:53:11 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=1011196954ab&repo=tools ***

go.tools/go/types, cmd/gotype: fix early bailout

Clients must have chance to look at panics they
are raising.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/23820043

Expand All Messages | Collapse All Messages