Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 23820043: code review 23820043: go.tools/go/types, cmd/gotype: fix early bailout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by gri
Modified:
12 years, 4 months ago
Reviewers:
adonovan
CC:
adonovan, golang-dev
Visibility:
Public.

Description

go.tools/go/types, cmd/gotype: fix early bailout Clients must have chance to look at panics they are raising.

Patch Set 1 #

Patch Set 2 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 5 : diff -r db483a0d26e3 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M cmd/gotype/gotype.go View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M go/types/check.go View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
12 years, 4 months ago (2013-11-08 20:47:39 UTC) #1
adonovan
LGTM https://codereview.appspot.com/23820043/diff/60001/go/types/check.go File go/types/check.go (right): https://codereview.appspot.com/23820043/diff/60001/go/types/check.go#newcode176 go/types/check.go:176: panic(p) Great! I have long disliked the fact ...
12 years, 4 months ago (2013-11-08 20:50:27 UTC) #2
gri
12 years, 4 months ago (2013-11-08 20:53:11 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=1011196954ab&repo=tools ***

go.tools/go/types, cmd/gotype: fix early bailout

Clients must have chance to look at panics they
are raising.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/23820043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b