Issue 23800044: Remove a race condition from sandbox deployment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23800044: Remove a race condition from sandbox deployment

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gary.poster

Modified:
10 years, 6 months ago

Reviewers:
bac, mp+194581

Visibility:
Public.

Description

Remove a race condition from sandbox deployment Deploying to the sandbox will sometimes mis-position services, especially when you have a large bundle. I believe the cause is the race condition that this branch fixes. I also simplified some code that I thought was confusing. To QA, try deploying some big bundles. At the very least, it shouldn't be worse than it was before. If we're lucky, you'll see that the position is always right for the deployed bundles in the sandbox. https://code.launchpad.net/~gary/juju-gui/fixSandboxDeployRace/+merge/194581 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove a race condition from sandbox deployment #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -29 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View	4 chunks	+21 lines, -29 lines	0 comments	Download
M	test/test_fakebackend.js	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

10 years, 6 months ago (2013-11-08 20:20:44 UTC) #3

*** Submitted:

Remove a race condition from sandbox deployment

Deploying to the sandbox will sometimes mis-position services, especially when
you have a large bundle. I believe the cause is the race condition that this
branch fixes.

I also simplified some code that I thought was confusing.

To QA, try deploying some big bundles.  At the very least, it shouldn't be worse
than it was before.  If we're lucky, you'll see that the position is always
right for the deployed bundles in the sandbox.

R=bac
CC=
https://codereview.appspot.com/23800044

Expand All Messages | Collapse All Messages