Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 236750043: Add methods to public API to determine the mode in use. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by kpreid_google
Modified:
11 years, 6 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

This is currently useful for migrating off ES5/3 while still using already-cajoled content when possible. It has been designed to be future-proof in case of the introduction of a new or variant implementation strategy, by offering independent answers to "is this ES5/3" and "is this SES" rather than an enumeration (or boolean), which could not express e.g. "this is not actually SES, but if you haven't heard of it you should treat it like SES". @ 99f9d8a81eff716ff93daa014fadd3493b0df0a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/com/google/caja/plugin/caja.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/es53-frame-group.js View 1 chunk +7 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/test-cajajs-invocation.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
kpreid_google
11 years, 6 months ago (2015-04-27 20:36:49 UTC) #1
kpreid_google
Please review for "is this a good idea" as well as "is the code good". ...
11 years, 6 months ago (2015-04-27 20:38:35 UTC) #2
MarkM
11 years, 6 months ago (2015-04-27 22:56:00 UTC) #3
LGTM

The general idea seems fine. I don't love it but I can't think of anything
better.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b