Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3666)

Issue 23660043: Allow implicit juju-* relations to be valid.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rharding
Modified:
10 years, 6 months ago
Reviewers:
benji, mp+194535
Visibility:
Public.

Description

Allow implicit juju-* relations to be valid. - https://juju.ubuntu.com/docs/authors-implicit-relations.html - juju-* is a namespace for implicit juju relations all charms support. This adds a check for relations that start with juju- and auto approve them in proof. - Charms are not allowed to create any relation of their own that start with juju-, so it's safe to assume anything that starts with this is a safe implicit relation. https://code.launchpad.net/~rharding/charmworld/support-implicit-relations/+merge/194535 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/lib/proof.py View 1 chunk +9 lines, -0 lines 0 comments Download
M charmworld/lib/tests/test_proof.py View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rharding
Please take a look.
10 years, 6 months ago (2013-11-08 15:40:19 UTC) #1
benji
10 years, 6 months ago (2013-11-08 15:42:53 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b