Issue 236180043: 4 - Tregubova Masha

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 236180043: 4 - Tregubova Masha

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by masha.fbb57

Modified:
8 years, 11 months ago

Reviewers:
shad.python

Visibility:
Public.

Description

Код для моделирования океана и юнит-тесты для функций жертвы и хищника.

Patch Set 1 #

Patch Set 2 : test_prey was not been concatinate, main.py was changed #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+613 lines, -1 line)			Patch
M	Ocean.py	View	1 chunk	+81 lines, -0 lines	0 comments	Download
M	main.py	View	1 chunk	+269 lines, -0 lines	2 comments	Download
M	ocean_cell.py	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	predator.py	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	prey.py	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	report.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test_predator.py	View	1 chunk	+69 lines, -0 lines	0 comments	Download
M	test_prey.py	View	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

shad.python

8 years, 11 months ago (2015-05-21 14:53:16 UTC) #2

Message was sent while issue was closed.

https://codereview.appspot.com/236180043/diff/20001/main.py
File main.py (right):

https://codereview.appspot.com/236180043/diff/20001/main.py#newcode9
main.py:9: class Predator(object):
Этот класс и класс Prey ниже нужно включить в иерархию классов с общим предком,
особенно если учесть одинаковый код в некоторых методах.
Методы moving и т.п. будут при этом вызываться полиморфно.

https://codereview.appspot.com/236180043/diff/20001/main.py#newcode256
main.py:256: print "--cfg config file path. If this diretory print filename
only"
А как насчет модуля argparse?

Expand All Messages | Collapse All Messages