Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 235980043: Update incipit snippets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by PhilEHolmes
Modified:
8 years, 12 months ago
Reviewers:
email, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This is in response to Issue 3981, which identified multiple methods of creating incipits in the LSR and docs. I have deleted 2 of the LSR snippets in the LSR and updated the 3rd to match the syntax introduced in 2.19.16. I have imported the LSR and edited the templates to use the newly named snippet. Finally nuked build and rebuilt docs with success. Since this is almost all LSR work, we wouldn't normally actually review it, but I'd like a patchy sanity check and ditto from contributors.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -701 lines) Patch
M Documentation/ca/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/cs/learning/templates.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/es/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/fr/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/it/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/ja/learning/templates.itely View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/nl/learning/templates.itely View 2 chunks +3 lines, -5 lines 0 comments Download
M Documentation/snippets/ancient-notation.snippet-list View 1 chunk +0 lines, -2 lines 0 comments Download
D Documentation/snippets/ancient-notation-template----modern-transcription-of-mensural-music.ly View 1 chunk +0 lines, -250 lines 0 comments Download
M Documentation/snippets/conducting-signs,-measure-grouping-signs.ly View 2 chunks +2 lines, -2 lines 1 comment Download
M Documentation/snippets/incipit.ly View 7 chunks +65 lines, -124 lines 0 comments Download
A Documentation/snippets/new/incipit.ly View 1 chunk +208 lines, -0 lines 0 comments Download
M Documentation/snippets/real-music.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/really-cool.snippet-list View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/snippets/specific-notation.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/template.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download
D Documentation/snippets/transcription-of-ancient-music-with-incipit.ly View 1 chunk +0 lines, -278 lines 0 comments Download
M Documentation/snippets/tweaks-and-overrides.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/workaround.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
PhilEHolmes
Please review
9 years ago (2015-05-06 09:34:38 UTC) #1
Trevor Daniels
I haven't checked incipit.ly, but otherwise it looks fine apart from what appears to be ...
9 years ago (2015-05-06 11:40:57 UTC) #2
email_philholmes.net
9 years ago (2015-05-06 15:38:24 UTC) #3
----- Original Message ----- 
From: <tdanielsmusic@googlemail.com>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Wednesday, May 06, 2015 12:40 PM
Subject: Re: Update incipit snippets (issue 235980043 by 
PhilEHolmes@googlemail.com)


>I haven't checked incipit.ly, but otherwise it looks fine apart from
> what appears to be an inadvertent change which needs investigating.
>
>
>
https://codereview.appspot.com/235980043/diff/1/Documentation/snippets/conduc...
> File Documentation/snippets/conducting-signs,-measure-grouping-signs.ly
> (right):
>
>
https://codereview.appspot.com/235980043/diff/1/Documentation/snippets/conduc...
> Documentation/snippets/conducting-signs,-measure-grouping-signs.ly:31:
> setting in @@file@{scm/time-signature-settings.scm@}:
> Is this change intentional?  The original looks right.  Looks like
> someone edited this snippet in Documentation/snippets without adding the
> change to snippets/new.
>
> https://codereview.appspot.com/235980043/

Looks like it's a change been made in the LSR, to try to use the file format 
of TeX, but which gets escaped when it's exported.

I guess the simplest fix is not to bother with @file in the snippet, but 
just use <code></code>

I'll do this soon, but not necessarily as a part of this specific patch, if 
that's OK.

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b