Issue 23440043: Migrate manual provisioning to API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23440043: Migrate manual provisioning to API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+194445, axw

Visibility:
Public.

Description

Migrate manual provisioning to API Manual provisioning now works using the API. Two new client endpoints are provided: InjectMachines MachineConfig The MachineConfig API is similar to the ContainerConfig used by the local provider, however more information is required in order to handle provisioning bootstrap as well as normal host nodes. Some refactoring of the ProvisionManchine method was also done to split it into smaller chunks. https://code.launchpad.net/~wallyworld/juju-core/cli-api-manualprovider/+merge/194445 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+437 lines, -160 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/manual/provisioner.go	View	4 chunks	+111 lines, -120 lines	0 comments	Download
M	environs/manual/provisioner_test.go	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	state/api/client.go	View	2 chunks	+24 lines, -0 lines	1 comment	Download
M	state/api/params/params.go	View	4 chunks	+31 lines, -6 lines	0 comments	Download
M	state/apiserver/client/client.go	View	4 chunks	+119 lines, -25 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	3 chunks	+138 lines, -0 lines	0 comments	Download
M	state/apiserver/client/tools.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

On 2013/11/08 04:55:53, wallyworld wrote: > Please take a look. Very nice, LGTM.

10 years, 6 months ago (2013-11-08 06:00:42 UTC) #2

axw

10 years, 6 months ago (2013-11-08 06:00:51 UTC) #3

https://codereview.appspot.com/23440043/diff/1/state/api/client.go
File state/api/client.go (right):

https://codereview.appspot.com/23440043/diff/1/state/api/client.go#newcode11
state/api/client.go:11: //	"launchpad.net/juju-core/environs/cloudinit"
Delete me

Expand All Messages | Collapse All Messages