Hello golang-dev@googlegroups.com (cc: Joe Poirier), I'd like you to review this change.
http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go File src/pkg/os/file_windows.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go#ne... src/pkg/os/file_windows.go:66: // Imitating unix behavior by replacing syscall.ERROR_PATH_NOT_FOUND with s/unix/Unix/ http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go#ne... src/pkg/os/file_windows.go:67: // os.ENOTDIR, not sure if we should go into that length. s/,/./ s/not/Not/ s/ length// http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/os_test.go#newcode82 src/pkg/os/os_test.go:82: func areEqual(name1, name2 string) (r bool) { s/areEqual/equal/ http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go File src/pkg/os/path_test.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go#newco... src/pkg/os/path_test.go:108: // Determine, if we should run the following test. s/,// http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go#newco... src/pkg/os/path_test.go:110: if syscall.OS == "windows" { you could fold these test together but if you want to keep the windows test separate, that's ok
Thanks for review. http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go File src/pkg/os/file_windows.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go#ne... src/pkg/os/file_windows.go:66: // Imitating unix behavior by replacing syscall.ERROR_PATH_NOT_FOUND with On 2010/10/04 05:48:00, r wrote: > s/unix/Unix/ Done. http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/file_windows.go#ne... src/pkg/os/file_windows.go:67: // os.ENOTDIR, not sure if we should go into that length. On 2010/10/04 05:48:00, r wrote: > s/,/./ > s/not/Not/ > s/ length// Done. http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/os_test.go#newcode82 src/pkg/os/os_test.go:82: func areEqual(name1, name2 string) (r bool) { On 2010/10/04 05:48:00, r wrote: > s/areEqual/equal/ Done. http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go File src/pkg/os/path_test.go (right): http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go#newco... src/pkg/os/path_test.go:108: // Determine, if we should run the following test. On 2010/10/04 05:48:00, r wrote: > s/,// Done. http://codereview.appspot.com/2343043/diff/2001/src/pkg/os/path_test.go#newco... src/pkg/os/path_test.go:110: if syscall.OS == "windows" { On 2010/10/04 05:48:00, r wrote: > you could fold these test together but if you want to keep the windows test > separate, that's ok I will keep them separate, because I want both comments separate.
Hello golang-dev@googlegroups.com, r (cc: Joe Poirier, golang-dev@googlegroups.com), Please take another look.
LGTM On Monday, October 4, 2010, <alex.brainman@gmail.com> wrote: > Hello golang-dev@googlegroups.com, r (cc: Joe Poirier, > golang-dev@googlegroups.com), > > Please take another look. > > > http://codereview.appspot.com/2343043/ >
*** Submitted as http://code.google.com/p/go/source/detail?r=46c566a29e1f *** os: make tests work on windows Fixes issue 1105. R=golang-dev, r CC=Joe Poirier, golang-dev http://codereview.appspot.com/2343043
