code review 2343043: os: make tests work on windows

src/pkg/os/path_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package os_test
 
 import (
         . "os"
         "testing"
+        "syscall"
 )
 
 func TestMkdirAll(t *testing.T) {
         // Create new dir, in _obj so it will get
         // cleaned up by make if not by us.
         path := "_obj/_TestMkdirAll_/dir/./dir2"
         err := MkdirAll(path, 0777)
         if err != nil {
                 t.Fatalf("MkdirAll %q: %s", path, err)
         }
@@ skipping 77 matching lines @@
                 t.Fatalf("create %q: %s", fpath, err)
         }
         fd.Close()
         if err = RemoveAll(path); err != nil {
                 t.Fatalf("RemoveAll %q (second): %s", path, err)
         }
         if _, err := Lstat(path); err == nil {
                 t.Fatalf("Lstat %q succeeded after RemoveAll (second)", path)
         }
 
-        if Getuid() != 0 { // Test fails as root
+        // Determine, if we should run the following test.

[r, 2010/10/04 05:48:00]

s/,//

[brainman, 2010/10/04 06:16:07]

Done.

+        testit := true
+        if syscall.OS == "windows" {

[r, 2010/10/04 05:48:00]

you could fold these test together but if you want to keep the windows test
separate, that's ok

[brainman, 2010/10/04 06:16:07]

I will keep them separate, because I want both comments separate.

+                // Chmod is not supported under windows.
+                testit = false
+        } else {
+                // Test fails as root.
+                testit = Getuid() != 0
+        }
+        if testit {
                 // Make directory with file and subdirectory and trigger error.
                 if err = MkdirAll(dpath, 0777); err != nil {
                         t.Fatalf("MkdirAll %q: %s", dpath, err)
                 }
 
                 for _, s := range []string{fpath, dpath + "/file1", path + "/zzz"} {
                         fd, err = Open(s, O_WRONLY|O_CREAT, 0666)
                         if err != nil {
                                 t.Fatalf("create %q: %s", s, err)
                         }
@@ skipping 25 matching lines @@
                         }
                 }
         }
         if err = RemoveAll(path); err != nil {
                 t.Fatalf("RemoveAll %q after partial RemoveAll: %s", path, err)
         }
         if _, err := Lstat(path); err == nil {
                 t.Fatalf("Lstat %q succeeded after RemoveAll (final)", path)
         }
 }