Issue 233400043: ShadPython - 4 - Alexander Timin - CS-2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 233400043: ShadPython - 4 - Alexander Timin - CS-2

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by alexander.timin

Modified:
8 years, 11 months ago

Reviewers:
shad.python

Visibility:
Public.

More Reviews

Description

ShadPython - 4 - Alexander Timin - CS-2

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+357 lines, -0 lines)			Patch
M	main.py	View	1 chunk	+57 lines, -0 lines	0 comments	Download
M	ocean.py	View	1 chunk	+230 lines, -0 lines	1 comment	Download
M	ocean_ut.py	View	1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

shad.python

8 years, 11 months ago (2015-05-20 21:29:26 UTC) #2

https://codereview.appspot.com/233400043/diff/1/ocean.py
File ocean.py (right):

https://codereview.appspot.com/233400043/diff/1/ocean.py#newcode198
ocean.py:198: can_eat = (isinstance(self[pos_to], Herbivore) and
Кажется, что "поедание" было бы удобнее обрабатывать прямо в
Carnivore.simulate_step() - там это более естественно и не нужно определять с
помощью специальных проверок.

Expand All Messages | Collapse All Messages