Issue 233370043: ShadPython - 4 - Dmitrii Ivanovskii - student FIVT

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 233370043: ShadPython - 4 - Dmitrii Ivanovskii - student FIVT

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by ivanovskiy.dmitriy

Modified:
8 years, 11 months ago

Reviewers:
shad.python

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Pep8 remarks #

Total comments: 1

Patch Set 3 : Improve cells inheritance #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -64 lines)			Patch
	M	ocean.py	View	1 2	7 chunks	+65 lines, -64 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

shad.python

8 years, 11 months ago (2015-05-21 14:26:09 UTC) #2

Единственный комментарий очень важен.

https://codereview.appspot.com/233370043/diff/20001/ocean.py
File ocean.py (right):

https://codereview.appspot.com/233370043/diff/20001/ocean.py#newcode129
ocean.py:129: if cell.__class__ == Predator:
Вместо того, чтобы проверять это, можно полиморфно вызывать метод типа do() в
классе-наследнике Animal (лучше сделать единую иерархию классов, начиная от
Cell) и передавать туда объект ocean.
Тогда сразу кода в этой функции станет в 5 раз меньше.

Expand All Messages | Collapse All Messages