Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 232850043: Rename makefile variable TMP

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by trueroad
Modified:
8 years, 11 months ago
Reviewers:
pkx166h, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rename makefile variable TMP Windows (cygwin and mingw) system uses environment variable TMP for a special purpose. It can not be used for other purpose like makefile variable.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M input/regression/abc2ly/GNUmakefile View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/midi/GNUmakefile View 1 chunk +2 lines, -2 lines 0 comments Download
M stepmake/stepmake/metafont-rules.make View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
pkx166h
Patch on countdown for April 27th
8 years, 11 months ago (2015-04-24 06:49:59 UTC) #1
pkx166h
Patch counted down - please push
8 years, 11 months ago (2015-04-27 15:03:36 UTC) #2
pkx166h
author Masamichi Hosoda <trueroad@sea.plala.or.jp> Tue, 28 Apr 2015 13:29:52 +0000 (14:29 +0100) committer James Lowe ...
8 years, 11 months ago (2015-04-28 14:03:23 UTC) #3
dak
8 years, 11 months ago (2015-04-28 14:31:45 UTC) #4
pkx166h@gmail.com writes:

> author	Masamichi Hosoda <trueroad@sea.plala.or.jp>	
> 	Tue, 28 Apr 2015 13:29:52 +0000 (14:29 +0100)
> committer	James Lowe <pkx166h@gmail.com>	
> 	Tue, 28 Apr 2015 14:02:06 +0000 (15:02 +0100)
> commit	8dd74d9902782edbd3a1f0dddcaeca29759b7be1
>
> https://codereview.appspot.com/232850043/

Well, I have just given Masamichi-san push access so that he could take
care of this himself, but it would appear that he'll have to wait for
the next patch now...

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b