Issue 232850043: Rename makefile variable TMP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 232850043: Rename makefile variable TMP

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by trueroad

Modified:
9 years, 11 months ago

Reviewers:
pkx166h, dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Rename makefile variable TMP Windows (cygwin and mingw) system uses environment variable TMP for a special purpose. It can not be used for other purpose like makefile variable.

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	input/regression/abc2ly/GNUmakefile	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	input/regression/midi/GNUmakefile	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	stepmake/stepmake/metafont-rules.make	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pkx166h

author Masamichi Hosoda <trueroad@sea.plala.or.jp> Tue, 28 Apr 2015 13:29:52 +0000 (14:29 +0100) committer James Lowe ...

9 years, 11 months ago (2015-04-28 14:03:23 UTC) #3

dak

9 years, 11 months ago (2015-04-28 14:31:45 UTC) #4

pkx166h@gmail.com writes:

> author	Masamichi Hosoda <trueroad@sea.plala.or.jp>	
> 	Tue, 28 Apr 2015 13:29:52 +0000 (14:29 +0100)
> committer	James Lowe <pkx166h@gmail.com>	
> 	Tue, 28 Apr 2015 14:02:06 +0000 (15:02 +0100)
> commit	8dd74d9902782edbd3a1f0dddcaeca29759b7be1
>
> https://codereview.appspot.com/232850043/

Well, I have just given Masamichi-san push access so that he could take
care of this himself, but it would appear that he'll have to wait for
the next patch now...

-- 
David Kastrup

Expand All Messages | Collapse All Messages