Issue 232830043: Implement the change set API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 232830043: Implement the change set API.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by frankban

Modified:
9 years ago

Reviewers:
mp+256979, jeff.pihach, matthew.scott

Visibility:
Public.

Description

Implement the change set API. The new WebSocket endpoints are described in the MP, and will be used by the Juju GUI and by quickstart to generate the uncommitted state of bundles. https://code.launchpad.net/~frankban/charms/trusty/juju-gui/proto-changeset/+merge/256979 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Implement the change set API. #

Patch Set 3 : Implement the change set API. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+696 lines, -45 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	deps/jujubundlelib-0.1.3.tar.gz	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	server-requirements.pip	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	server/guiserver/__init__.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	server/guiserver/apps.py	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	server/guiserver/bundles/__init__.py	View	1 chunk	+128 lines, -0 lines	0 comments	Download
M	server/guiserver/bundles/base.py	View	2 chunks	+48 lines, -1 line	0 comments	Download
M	server/guiserver/bundles/utils.py	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	server/guiserver/bundles/views.py	View	2 chunks	+116 lines, -0 lines	0 comments	Download
M	server/guiserver/handlers.py	View	6 chunks	+61 lines, -15 lines	0 comments	Download
M	server/guiserver/tests/bundles/test_utils.py	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	server/guiserver/tests/bundles/test_views.py	View	2 chunks	+207 lines, -0 lines	0 comments	Download
M	server/guiserver/tests/helpers.py	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	server/guiserver/tests/test_apps.py	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	server/guiserver/tests/test_auth.py	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	server/guiserver/tests/test_handlers.py	View	4 chunks	+101 lines, -5 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

frankban

On 2015/04/23 16:09:15, matthew.scott wrote: > LGTM Really great work, Francesco, thank you Thank you ...

9 years ago (2015-04-23 16:11:23 UTC) #5

frankban

9 years ago (2015-04-23 16:14:15 UTC) #6

*** Submitted:

Implement the change set API.

The new WebSocket endpoints are described in the
MP, and  will be used by the Juju GUI and by 
quickstart to generate the uncommitted state of
bundles.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/232830043

Expand All Messages | Collapse All Messages