Issue 23250043: runtime: experiment for running hash map operations on ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23250043: runtime: experiment for running hash map operations on ...

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by khr

Modified:
12 years, 12 months ago

Reviewers:

Visibility:
Public.

Description

runtime: experiment for running hash map operations on the g0 stack. benchmark old ns/op new ns/op delta BenchmarkMegMap 19 22 +13.40% BenchmarkMegOneMap 11 16 +37.82% BenchmarkMegEqMap 60892 61287 +0.65% BenchmarkMegEmptyMap 3 8 +153.77% BenchmarkSmallStrMap 18 22 +20.00% BenchmarkMapStringKeysEight_16 21 22 +5.19% BenchmarkMapStringKeysEight_32 18 23 +27.32% BenchmarkMapStringKeysEight_64 18 23 +27.32% BenchmarkMapStringKeysEight_1M 18 23 +26.63% BenchmarkIntMap 16 18 +14.63% BenchmarkRepeatedLookupStrMapKey32 33 41 +23.58% BenchmarkRepeatedLookupStrMapKey1M 277729 277790 +0.02% BenchmarkSameLengthMap 4 10 +149.43% looks like an overhead of about 3-6ns per call

Patch Set 1 #

Patch Set 2 : diff -r e6794866ebeb https://khr%40golang.org@code.google.com/p/go/ #

Created: 12 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -58 lines)			Patch
M	src/cmd/gc/builtin.c	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/cmd/gc/runtime.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/asm_amd64.s	View	1	1 chunk	+134 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/hashmap_fast.c	View	1	13 chunks	+30 lines, -38 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/stack.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download