Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3419)

Issue 2324041: Add svn revision to version number (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by jeremy.wadsack
Modified:
13 years, 7 months ago
Reviewers:
Michael Frederick
CC:
npr-android_googlegroups.com
Base URL:
http://npr-android-app.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Per email discussion this changes the third component of the version number to match the svn revision of the code currently being built. e.g. 1.3.108. This is the patch for the version _1.x branch, although it should be the same for the trunk. If this is approved, I'll apply to both branch and trunk.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
Npr/.externalToolBuilders/org.npr.android.AddSvnRevisionToVersion.launch View 1 chunk +22 lines, -0 lines 0 comments Download
Npr/.project View 1 chunk +11 lines, -1 line 0 comments Download
Npr/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
Npr/src/org/npr/android/news/AboutActivity.java View 1 chunk +0 lines, -1 line 0 comments Download
Npr/svn-revision.build.xml View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 2
jeremy.wadsack
13 years, 7 months ago (2010-09-29 23:44:55 UTC) #1
Michael Frederick
13 years, 7 months ago (2010-10-01 16:18:50 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b