Issue 23240043: Remove remaining old unused notifications code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23240043: Remove remaining old unused notifications code.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by jeff.pihach

Modified:
10 years, 5 months ago

Reviewers:
mp+194422, gary.poster

Visibility:
Public.

Description

Remove remaining old unused notifications code. https://code.launchpad.net/~hatch/juju-gui/remove-old-notifications/+merge/194422 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove remaining old unused notifications code. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -68 lines)			Patch
M	CHANGES.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	3 chunks	+0 lines, -19 lines	0 comments	Download
D	app/templates/notifications_overview.handlebars	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	app/views/notifications.js	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

No tests were removed as part of this branch because the tests for this section ...

10 years, 5 months ago (2013-11-07 21:31:16 UTC) #2

gary.poster

LGTM. I wonder if we should delete the skipped tests. Do their existence bring value ...

10 years, 5 months ago (2013-11-07 21:35:04 UTC) #3

jeff.pihach

Thanks for the review! We left them in because we should have tests for the ...

10 years, 5 months ago (2013-11-07 21:43:43 UTC) #4

jeff.pihach

10 years, 5 months ago (2013-11-07 21:48:19 UTC) #5

*** Submitted:

Remove remaining old unused notifications code.

R=gary.poster
CC=
https://codereview.appspot.com/23240043

Expand All Messages | Collapse All Messages