Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 231760044: TBR: i#1686 decoder testing: add api.disA32 and api.disT32 binary decoding tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by bruening
Modified:
11 years, 2 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1686 decoder testing: add api.disA32 and api.disT32 binary decoding tests Adds a new helper app api.dis-create which takes a large random binary and pulls out a subset of it that contains the head of the file and then caps the count of each opcode in order to create a manageable pre-commit-suite test. It also appends a few hardcoded entries for rare opcodes to ensure coverage. Adds two new tests, api.disA32 and api.disT32, which use the result of the api.dis-create helper and disassemble their own input binaries. The expected output for now is the DR format (already compared for register usage with Capstone). Eventually we want to finish -syntax_arm and use that as the format to check all the operands as well. Splits up the tobuild_api() routine to support this. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30041 lines, -6319 lines) Patch
M suite/tests/CMakeLists.txt View 1 4 chunks +50 lines, -23 lines 0 comments Download
M suite/tests/api/dis.c View 1 3 chunks +12 lines, -4 lines 0 comments Download
M suite/tests/api/dis.runcmp View 1 1 chunk +1 line, -1 line 0 comments Download
D suite/tests/api/dis.template View 1 1 chunk +0 lines, -6253 lines 0 comments Download
A suite/tests/api/dis-armA32.expect View 1 1 chunk +14699 lines, -0 lines 0 comments Download
A suite/tests/api/dis-armA32-randtest.raw View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A suite/tests/api/dis-armT32.expect View 1 1 chunk +15205 lines, -0 lines 0 comments Download
A suite/tests/api/dis-armT32-randtest.raw View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + suite/tests/api/dis-create.c View 1 2 chunks +76 lines, -40 lines 0 comments Download

Messages

Total messages: 2
bruening
11 years, 2 months ago (2015-04-18 00:43:19 UTC) #1
bruening
11 years, 2 months ago (2015-04-18 00:43:50 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/1faa08248d1528cd1f3839e6e6cde33...

Final commit log: 
---------------
i#1686 decoder testing: add api.disA32 and api.disT32 binary decoding tests

Adds a new helper app api.dis-create which takes a large random binary and
pulls out a subset of it that contains the head of the file and then caps
the count of each opcode in order to create a manageable pre-commit-suite
test.  It also appends a few hardcoded entries for rare opcodes to ensure
coverage.

Adds two new tests, api.disA32 and api.disT32, which use the result of the
api.dis-create helper and disassemble their own input binaries.  The
expected output for now is the DR format (already compared for register
usage with Capstone).  Eventually we want to finish -syntax_arm and use
that as the format to check all the operands as well.

Splits up the tobuild_api() routine to support this.

Review-URL: https://codereview.appspot.com/231760044
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b