Issue 2316043: Alter missing API message to be more helpful

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2316043: Alter missing API message to be more helpful (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by jeremy.wadsack

Modified:
13 years, 6 months ago

Reviewers:
Michael Frederick

Base URL:
http://npr-android-app.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Per discussion on list, this provides better instructions and has an embedded hyperlink.

Patch Set 2 : Updated with short URL #

Patch Set 3 : Fixed URL hyperlink #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
		Npr/res/values/strings.xml	View	1 2	1 chunk	+4 lines, -4 lines	1 comment	Download
		Npr/src/org/npr/android/news/Main.java	View		2 chunks	+15 lines, -2 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Michael Frederick

LGTM http://codereview.appspot.com/2316043/diff/4003/Npr/res/values/strings.xml File Npr/res/values/strings.xml (right): http://codereview.appspot.com/2316043/diff/4003/Npr/res/values/strings.xml#newcode81 Npr/res/values/strings.xml:81: Then login, go to \"Manage\" and click \"Generate ...

13 years, 6 months ago (2010-10-07 17:34:35 UTC) #1

jeremy.wadsack

13 years, 6 months ago (2010-10-07 17:39:04 UTC) #2

Quotes, if not escaped, don't show up in the dialog. I didn't see it
documented, but that's what happened.

Yeah, I only got all that from reading several different approaches here:
http://stackoverflow.com/questions/1997328/android-clickable-hyperlinks-in-al...

I'll add the link to the comments to provide background.

--
Jeremy Wadsack

On Thu, Oct 7, 2010 at 10:34 AM, <mfrederick@google.com> wrote:

> LGTM
>
>
> http://codereview.appspot.com/2316043/diff/4003/Npr/res/values/strings.xml
> File Npr/res/values/strings.xml (right):
>
>
>
http://codereview.appspot.com/2316043/diff/4003/Npr/res/values/strings.xml#ne...
> Npr/res/values/strings.xml:81: Then login, go to \"Manage\" and click
> \"Generate Key.\"
> Do quotes need to be escaped?
>
>
>
http://codereview.appspot.com/2316043/diff/4003/Npr/src/org/npr/android/news/...
> File Npr/src/org/npr/android/news/Main.java (right):
>
>
>
http://codereview.appspot.com/2316043/diff/4003/Npr/src/org/npr/android/news/...
> Npr/src/org/npr/android/news/Main.java:257: ((TextView)
> dialog.findViewById(android.R.id.message))
> Wow, that's inscrutable. :-)
>
> http://codereview.appspot.com/2316043/
>

Expand All Messages | Collapse All Messages