Issue 230990043: 3-dopusk - Davydov Vasya

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 230990043: 3-dopusk - Davydov Vasya

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by dexfrost89

Modified:
9 years ago

Reviewers:
belovpd, ilnur.gadelshin

Visibility:
Public.

More Reviews

Description

dijkstra_with_heap

Patch Set 1 #

Total comments: 7

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -0 lines)			Patch
	M	1.cpp.c	View		1 chunk	+128 lines, -0 lines	7 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

BelovPD

9 years ago (2015-04-26 00:46:22 UTC) #5

https://codereview.appspot.com/230990043/diff/1/1.cpp.c
File 1.cpp.c (right):

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode4
1.cpp.c:4: using namespace std;
using namespace std не пишем

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode32
1.cpp.c:32: vector<vector<vertex> > list_of_smejnost;  //sorry for this name
adjacency_list

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode33
1.cpp.c:33: vector<vertex> hlp;
Не надо использовать глобальные вектора и переменные

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode47
1.cpp.c:47: if(b * 2 + 1 < heap.size()) {
Странный иф, это можно добавить в условие цикла.

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode60
1.cpp.c:60: b *= 2;
Непонятно зачем здесь нужно дублирование кода

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode81
1.cpp.c:81: ans.push_back(-1);
Векторам можно сразу задать нужный размер и заполнять их, вместо использования
push_back

https://codereview.appspot.com/230990043/diff/1/1.cpp.c#newcode128
1.cpp.c:128: }
Очень много плохих названий переменных, надо оформить код хорошо.

Expand All Messages | Collapse All Messages