Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3154)

Issue 23000043: Improve bundle deployment error handling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by frankban
Modified:
10 years, 5 months ago
Reviewers:
bac, rharding, mp+194398
Visibility:
Public.

Description

Improve bundle deployment error handling. Workaround for http://bugs.python.org/issue1692335. Include a customized jujuclient tarball in the charm, The diff with the original is here: http://pastebin.ubuntu.com/6377430/ Add a first fix to the testing environment creation so that the local dependencies are installed when available. Also fixed the headers sent by the info handler. Tests: make unittest QA: I used this bundle: http://pastebin.ubuntu.com/6377441/ to live test the branch. Bootstrap a juju environment, run `make deploy` and then switch the gui source to lp:juju-gui. When everything is ready, try to deploy the bundle above: it will fail because it includes local charms, but the server will not explode, and it will be possible to deploy other valid bundles after the first one. The GUI user does not receive notifications, and that's normal since deployments are not yet watched by the GUI. Go to https://[GUI URL]/gui-server-info and you should find the deployment status to be completed with the expected error. https://code.launchpad.net/~frankban/charms/precise/juju-gui/improve-error-handling/+merge/194398 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve bundle deployment error handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M deps/jujuclient-0.13.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M hooks/utils.py View 1 chunk +3 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/handlers.py View 2 chunks +4 lines, -2 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 3 chunks +30 lines, -0 lines 0 comments Download
M server/guiserver/tests/test_handlers.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/requirements.pip View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 5 months ago (2013-11-07 18:19:56 UTC) #1
rharding
LGTM
10 years, 5 months ago (2013-11-07 18:55:56 UTC) #2
bac
LGTM, QA-A-OK https://codereview.appspot.com/23000043/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/23000043/diff/1/hooks/utils.py#newcode124 hooks/utils.py:124: # lp:~frankban/python-jujuclient/pickable-enverror. nice thanks for the branch ...
10 years, 5 months ago (2013-11-07 19:24:31 UTC) #3
frankban
10 years, 5 months ago (2013-11-07 19:43:14 UTC) #4
*** Submitted:

Improve bundle deployment error handling.

Workaround for http://bugs.python.org/issue1692335.

Include a customized jujuclient tarball in the
charm, The diff with the original is here:
http://pastebin.ubuntu.com/6377430/

Add a first fix to the testing environment creation
so that the local dependencies are installed
when available.

Also fixed the headers sent by the info handler.

Tests: make unittest

QA:
I used this bundle: http://pastebin.ubuntu.com/6377441/
to live test the branch.
Bootstrap a juju environment, run `make deploy` and then
switch the gui source to lp:juju-gui.
When everything is ready, try to deploy the bundle above:
it will fail because it includes local charms, but the
server will not explode, and it will be possible
to deploy other valid bundles after the first one.
The GUI user does not receive notifications, and that's
normal since deployments are not yet watched by the GUI.
Go to https://[GUI URL]/gui-server-info and you should
find the deployment status to be completed with the
expected error.

R=rharding, bac
CC=
https://codereview.appspot.com/23000043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b