Hook up container setup logic

Hook up container setup logic

The main focus of this branch is to wore up the logic to
intialise container infrastructure when they are first
provisioned. Right now, that means apt-get install any
required packages, but that may expand to include
downloading/sync images etc.

A new container.Initialisation interface is created, with
implementations for lxc and kvm. This allows the current
simple package install logic to be expanded later. The
lxc package install in cloudinit is removed since it is
no longer needed there.

The provisioner worker has been tweaked to add in kvm
support (but waiting on kvm broker). Some test code was
moved from the apt util to testbase to that the apt cmd
output could be captured in several tests.

https://code.launchpad.net/~wallyworld/juju-core/container-dependencies/+merge/195344

Requires: https://code.launchpad.net/~wallyworld/juju-core/lazy-container-provisioners/+merge/194795

(do not edit description out of merge proposal)

[wallyworld, 2013-11-15 06:46:35]

Please take a look.

[axw, 2013-11-15 07:48:16]

LGTM with below

https://codereview.appspot.com/22980045/diff/1/container/interface.go
File container/interface.go (right):

https://codereview.appspot.com/22980045/diff/1/container/interface.go#newcode33
container/interface.go:33: // Initialiser is responsible for performing the
steps required to initialise
HostInitializer would be more informative: I expected it to be about
initialising the container itself.

Also, I've been told that we should standardize on U.S. spellings.

https://codereview.appspot.com/22980045/diff/1/container/kvm/initialisation.go
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/22980045/diff/1/container/kvm/initialisation.g...
container/kvm/initialisation.go:24: func NewContainerInitialiser()
container.Initialiser {
I would prefer NewHostInitializer, to go with the other suggestion.

https://codereview.appspot.com/22980045/diff/1/testing/testbase/cmd.go
File testing/testbase/cmd.go (right):

https://codereview.appspot.com/22980045/diff/1/testing/testbase/cmd.go#newcode11
testing/testbase/cmd.go:11: // actual command and it's output back via a
channel, and returns the error
s/it's/its/

[wallyworld, 2013-11-18 03:15:45]

https://codereview.appspot.com/22980045/diff/1/container/interface.go
File container/interface.go (right):

https://codereview.appspot.com/22980045/diff/1/container/interface.go#newcode33
container/interface.go:33: // Initialiser is responsible for performing the
steps required to initialise
On 2013/11/15 07:48:17, axw wrote:
> HostInitializer would be more informative: I expected it to be about
> initialising the container itself.
>
 
Done.

> Also, I've been told that we should standardize on U.S. spellings.

Ewww. I checked with Tim and he said there's no such policy :-)

https://codereview.appspot.com/22980045/diff/1/container/kvm/initialisation.go
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/22980045/diff/1/container/kvm/initialisation.g...
container/kvm/initialisation.go:24: func NewContainerInitialiser()
container.Initialiser {
On 2013/11/15 07:48:17, axw wrote:
> I would prefer NewHostInitializer, to go with the other suggestion.

Done.

https://codereview.appspot.com/22980045/diff/1/testing/testbase/cmd.go
File testing/testbase/cmd.go (right):

https://codereview.appspot.com/22980045/diff/1/testing/testbase/cmd.go#newcode11
testing/testbase/cmd.go:11: // actual command and it's output back via a
channel, and returns the error
On 2013/11/15 07:48:17, axw wrote:
> s/it's/its/

Done.